Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/websocket readiness #10

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

TylerEther
Copy link

Description of change

Fixes #9 through the implementation of the following logic:

  • If the ws is closing or closed, it does not try performing the call. Instead, it immediately falls back.
  • If the ws is still connecting, it immediately falls back. If the fallbacks fail, it'll perform the call using the provided ws providers (that were in the connecting state) in reverse order.

Other changes:

  • Introduces a new dependency: await-timeout
    • Reason: Test cases using the old promiseWithTimeout failed with odd behavior. They work nicely using await-timeout.

Pull-Request Checklist

  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions outlined in the conventional commit spec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Websockets that are not open can lead to stalling
1 participant