Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

Upgrade the ascoltatori kafka broker to kafka-node 4.0.0 #195

Open
karthicks opened this issue Feb 7, 2019 · 4 comments
Open

Upgrade the ascoltatori kafka broker to kafka-node 4.0.0 #195

karthicks opened this issue Feb 7, 2019 · 4 comments

Comments

@karthicks
Copy link

It appears that, currently, KafkaAscoltatore depends on an older ~0.5.8 version of kafka-node, and uses deprecated methods thereof, such as kafka.Client. Would it be possible to upgrade to kafka-node 4.0.0, and use the recommended kafka.KafkaClient instead, which connects directly to the kafka brokers, as opposed to going through zookeeper?

@user1m
Copy link

user1m commented Feb 27, 2019

+1
facing this issue as well. Doesn't look like this library is up to date w/ kafka-node

@vicary
Copy link

vicary commented Jun 17, 2019

This issue also prevents snappy support for node 12.

@user1m
Copy link

user1m commented Jun 20, 2019

@vicary we built a PubSub wrapper around kafka-node if you're using Kafka as your backing/broker. Check out: https://github.com/NeuCleans/kafka-pub-sub

@vicary
Copy link

vicary commented Jun 21, 2019

@user1m This is in fact an indirect dependency of serverless-appsync-offline, need this resolved to run unit tests in our CI pipelines.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants