Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lock upgrade issues in dev #143

Closed
gdestuynder opened this issue Aug 14, 2017 · 1 comment
Closed

Fix lock upgrade issues in dev #143

gdestuynder opened this issue Aug 14, 2017 · 1 comment

Comments

@gdestuynder
Copy link
Contributor

gdestuynder commented Aug 14, 2017

emailInputPlaceholder

The emailInputPlaceholder is no longer respected. This is a regression

Viorela writes

Ldap login form is asking for user name and password, instead of email and password. By that I understand that, for example, for [email protected] account the user name is vioia.

I tried to login using just 'vioia', but the login failed.

emailinputplaceholder bug

error argument

The error argument is lost with this.

Viorela writes : "error message for invalid ldap credentials is changed (probably to fit the change above?)"

error message changed

LDAP Login Form Expanded By Default

I'm not sure the root cause of this bug

Viorela writes "​When navigating to login page of reps-dev.allizom.org (which has ldap and passwordless login types available), the ldap login form is expanded by default and it cannot be collapsed. ​Trying to login with ldap when passwordless form is expanded results in browser console error. See: https://vimeo.com/229272072"

passwordless not working

Originally found in #141

@gdestuynder
Copy link
Contributor Author

revert by #150 (ie this issue is no longer needed, though fixes would still be needed if we were to pull the commits back in)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant