Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to newer lock and lock library, which fixes, the "remembered" #141

Merged
merged 1 commit into from
Aug 10, 2017

Conversation

gdestuynder
Copy link
Contributor

login for SAML initiated locks (for example this would trigger with
expensify and fail to login)

Note the new option is necessary as well because: auth0/lock#1077

I tested all known combinations on testrp in dev

login for SAML initiated locks (for example this would trigger with
expensify and fail to login)

Note the new option is necessary as well because: auth0/lock#1077

I tested all known combinations on testrp in dev
@gdestuynder gdestuynder requested review from jdow and gene1wood August 10, 2017 17:04
@gdestuynder gdestuynder merged commit db417b0 into mozilla-iam:master Aug 10, 2017
@gene1wood
Copy link
Contributor

This covers a lot of change, bringing the lock from 10.5 to 10.18 and auth0.js from 7.4 to 7.6. Have you read through the changelogs for these versions to know what will change with this upgrade?

@gene1wood
Copy link
Contributor

The emailInputPlaceholder is no longer respected. This is a regression

Viorela writes

Ldap login form is asking for user name and password, instead of email and password. By that I understand that, for example, for [email protected] account the user name is vioia.

I tried to login using just 'vioia', but the login failed.

emailinputplaceholder bug

@gene1wood
Copy link
Contributor

The error argument is lost with this.

Viorela writes : "error message for invalid ldap credentials is changed (probably to fit the change above?)"

error message changed

@gene1wood
Copy link
Contributor

I'm not sure the root cause of this bug

Viorela writes "​When navigating to login page of reps-dev.allizom.org (which has ldap and passwordless login types available), the ldap login form is expanded by default and it cannot be collapsed. ​Trying to login with ldap when passwordless form is expanded results in browser console error. See: https://vimeo.com/229272072"

passwordless not working

@gdestuynder
Copy link
Contributor Author

These issues have been reported by Viorela by our asking following this PR. The merge is required for testing and this is exactly what the DEV environment is made for.
Thanks for reporting them on the PR though as these needs to be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants