Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Display toast when new entry is saved #824

Closed
eliserichards opened this issue Jul 8, 2019 · 5 comments · Fixed by #1123
Closed

Display toast when new entry is saved #824

eliserichards opened this issue Jul 8, 2019 · 5 comments · Fixed by #1123
Assignees
Labels
effort-XS Expected to take less than a day for engineering to complete. enhancement Issue describes an improvement or addition to the product. feature-create feature-CUD QA-verified For the issues verified by QA

Comments

@eliserichards
Copy link
Contributor

eliserichards commented Jul 8, 2019

Depends on #821

Requirements

  • Display toast on display item screen to confirm new entry creation

image

Visual Design

Zeplin: https://zpl.io/2GRdAR3

Icon: success-icon.zip

@changecourse
Copy link
Contributor

Removing this from MVP functionality for 1.4.0.

Updated the functional requirements in #821 to transition from the create view to the read-only view of the login detail, removing the need for a confirmation toast at this time.

We can revisit if we feel this is necessary in the future. (After performing a competitive analysis of the feature, no one displays toast confirmations, it is implied by the routing to the read-only state)

@eliserichards
Copy link
Contributor Author

Is this still on the table for Skyline? @changecourse @sandysage

@eliserichards eliserichards added this to the 1.4.0 - Create milestone Sep 6, 2019
@eliserichards eliserichards added effort-S Expected to take less than a week for engineering to complete. enhancement Issue describes an improvement or addition to the product. labels Sep 6, 2019
@changecourse changecourse removed their assignment Oct 28, 2019
@changecourse
Copy link
Contributor

@eliserichards @sandysage Designs added to description. Let's be sure to account for this when we begin the manual create work.

@eliserichards eliserichards removed this from the 1.4.0 - Create milestone Jan 3, 2020
@jhugman
Copy link
Contributor

jhugman commented Jan 3, 2020

This would be a good time to rationalize our toasts and progress bars into the RoutePresenter, in the same way as we have done with DialogActions.

We should put all these into the activity XML rather than the separate fragment XML files.

@eliserichards eliserichards self-assigned this Jan 3, 2020
@eliserichards eliserichards added effort-XS Expected to take less than a day for engineering to complete. and removed effort-S Expected to take less than a week for engineering to complete. labels Jan 10, 2020
@eliserichards eliserichards added the QA-needed When needing QA Verification/Investigation label Jan 28, 2020
@eliserichards eliserichards added this to the 4.0.0 🆕 milestone Jan 29, 2020
@abodea
Copy link
Contributor

abodea commented Jan 31, 2020

Verified as fixed on v.4.0.0(6016) using Google Pixel 3 XL(Android 9), Samsung Galaxy S10+(Android 9).

@abodea abodea added QA-verified For the issues verified by QA and removed QA-needed When needing QA Verification/Investigation labels Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
effort-XS Expected to take less than a day for engineering to complete. enhancement Issue describes an improvement or addition to the product. feature-create feature-CUD QA-verified For the issues verified by QA
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants