Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

The device back button doesn't have the same functionality with the X button in Edit Login Mode #994

Closed
3 tasks done
abodea opened this issue Oct 18, 2019 · 1 comment · Fixed by #1062
Closed
3 tasks done

The device back button doesn't have the same functionality with the X button in Edit Login Mode #994

abodea opened this issue Oct 18, 2019 · 1 comment · Fixed by #1062
Assignees
@jhugman
Labels
defect Issue describes a defect that negatively impacts use. effort-M Expected to take a week for engineering to complete. feature-CUD feature-edit priority-P2 QA-verified For the issues verified by QA
Milestone
3.2.0 🦃

Comments

@abodea
Copy link
Contributor

abodea commented Oct 18, 2019 •
edited by jhugman
Loading

Proposed change:

  • detect if there have been any edits
  • if edits have been made, show back button/X button confirmation dialog
  • if no edits have been made, DO NOT SHOW confirmation dialog on back/X button clicks

Steps to reproduce

  1. Launch Lockwise.
  2. Login with valid credentials.
  3. Enter in the Login edit mode.
  4. Case 1: Tap on X(the pop-up is displayed asking if you really wanna dismiss the edit login screen)
    Case 2: Tap on the back button(the user is redirected to the account screen without any pop-up displayed).

Expected behavior

The pop-up is displayed even when tapping on the device back button.

Actual behavior

When using the device back button, there is no pop-up displayed.

Device & build information

  • Device: Google Pixel 3a XL(Android 9)
  • Build version: Latest build from master(18/10/2019)

Notes

Attachments:
ezgif-5-7862e57e2d1f
@abodea abodea added defect Issue describes a defect that negatively impacts use. feature-CUD feature-edit labels Oct 18, 2019
@marniepw marniepw added the effort-M Expected to take a week for engineering to complete. label Nov 5, 2019
@jhugman jhugman self-assigned this Nov 12, 2019
@jhugman jhugman mentioned this issue Nov 12, 2019
Merged
@eliserichards eliserichards added the QA-needed When needing QA Verification/Investigation label Nov 14, 2019
@eliserichards eliserichards added this to the 3.2.0 milestone Nov 15, 2019
@abodea
Copy link
Contributor Author

abodea commented Nov 18, 2019

Verified as fixed on 3.2.0 (Build 5522) with Google Pixel 3a XL(Android 10).

@abodea abodea added QA-verified For the issues verified by QA and removed QA-needed When needing QA Verification/Investigation labels Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jhugman jhugman

Labels
defect Issue describes a defect that negatively impacts use. effort-M Expected to take a week for engineering to complete. feature-CUD feature-edit priority-P2 QA-verified For the issues verified by QA
Projects
None yet
Milestone
3.2.0 🦃
5 participants
@jhugman @sandysage @marniepw @abodea @eliserichards