Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better validate the name field in the manifest #4904

Closed
willdurand opened this issue Jun 6, 2023 · 2 comments · Fixed by #4903
Closed

Better validate the name field in the manifest #4904

willdurand opened this issue Jun 6, 2023 · 2 comments · Fixed by #4903
Assignees
@willdurand
Labels
priority:p3 state:verified_fixed
Milestone
2023.06.22

Comments

@willdurand
Copy link
Member

willdurand commented Jun 6, 2023 •
edited by data-sync-user
Loading

See: mozilla/addons#9198

┆Issue is synchronized with this Jira Task
@willdurand willdurand self-assigned this Jun 6, 2023
@willdurand willdurand mentioned this issue Jun 6, 2023
Merged
@willdurand willdurand added this to the 2023.06.22 milestone Jun 8, 2023
@willdurand willdurand mentioned this issue Jun 8, 2023
Open
@ioanarusiczki
Copy link

@willdurand I don't see a tag for 6.8.0 so let me know when I can check this.
Thanks!

@ioanarusiczki
Copy link

@willdurand

  • When whitespaces are used in manifest.json for name or they're added before or after the name -> an error is raised

  • When I used one char for the name but without using whitespaces , let's say "name": "1" , this error is thrown together with "/name" must NOT have fewer than 2 " . Submission is not valid anyway but whitespaces haven't been used either, so let me know if I should file this edge case.

2 errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@willdurand willdurand

Labels
priority:p3 state:verified_fixed
Projects
None yet
Milestone
2023.06.22
Development

Successfully merging a pull request may close this issue.

Better validate add-on names mozilla/addons-linter
2 participants
@willdurand @ioanarusiczki