Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide performant implementations for common rules in the Fathom library #146

Closed
biancadanforth opened this issue Aug 30, 2019 · 1 comment

Comments

@biancadanforth
Copy link
Collaborator

biancadanforth commented Aug 30, 2019

As Fathom is used more and more for different applications, there may be a set of common rules (e.g. isVisible, #118 ) that the library could provide to make developing a Fathom ruleset more convenient and executing the ruleset more performant at the same time.

@erikrose
Copy link
Contributor

erikrose commented Sep 3, 2019

Absolutely! I hope to do this continually, as a side effect of factoring out repetition between rulesets. Is this really a task we can "check off" and finish, once and for all? If not, maybe we should close it. I'll do that now to save paperwork, but re-open if you disagree.

@erikrose erikrose closed this as completed Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants