Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Ink-editors cannot be "directly" deleted anymore #19126

Closed
Snuffleupagus opened this issue Nov 29, 2024 · 0 comments · Fixed by #19129
Closed

[Bug]: Ink-editors cannot be "directly" deleted anymore #19126

Snuffleupagus opened this issue Nov 29, 2024 · 0 comments · Fixed by #19129
Assignees
Labels
editor regression release-blocker Blocker for the upcoming release

Comments

@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Nov 29, 2024

Attach (recommended) or Link to PDF file

N/A

Web browser and its version

N/A

Operating system and its version

N/A

PDF.js version

master, or any version after PR #19093

Is the bug present in the latest PDF.js version?

Yes

Is a browser extension

No

Steps to reproduce the problem

  1. Load https://mozilla.github.io/pdf.js/web/viewer.html or http://localhost:8888/web/viewer.html.
  2. Enable the Ink-editor.
  3. Draw something.
  4. Remove the drawing by pressing Delete.

What is the expected behavior?

That the drawing is immediately removed, as was the case before PR #19093.

What went wrong?

The drawing must be "finished" first, e.g. by pressing Esc or clicking outside of the page, before it's possible to delete it.

Link to a viewer

No response

Additional context

I suppose that this could be the intended behaviour now, but since this was changed I figured that filing this wouldn't hurt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor regression release-blocker Blocker for the upcoming release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants