Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnail rendering glitch #6442

Closed
timvandermeij opened this issue Sep 11, 2015 · 2 comments
Closed

Thumbnail rendering glitch #6442

timvandermeij opened this issue Sep 11, 2015 · 2 comments
Assignees

Comments

@timvandermeij
Copy link
Contributor

After PR #6299 there is a (somewhat minor) visual glitch in the thumbnail viewer when a thumbnail is being rendered. See #6441 for a screenshot. I'm tentatively assigning this to @Snuffleupagus as he appears to have an idea on how to solve this.

I'm also adding https://stackoverflow.com/questions/14396356/force-firefox-to-render-empty-image-within-dimensions-specified-by-css for more documentation on how to possibly solve this. From that page it appears that this issue is Firefox-only.

@Snuffleupagus
Copy link
Collaborator

Conceptually, I'd actually prefer to re-factor this a bit.
My preferred solution would be to (again) render thumbnails on a visible canvas, and once the rendering is done convert to an image and then swap the elements; please see a WIP patch here.
That seems to me to be a slightly more robust solution over all, but unfortunately it doesn't seem to be working perfectly. When testing this there were intermittent flickering (at least in Firefox) when doing replaceChild, which didn't look particularly good.

Since we're kind of short on time here, before the next Firefox release, I choose to submit a much simpler fix which should be an improvement for now. We can then revisit this later on, if we want to.

@timvandermeij
Copy link
Contributor Author

I actually think this current patch does the work very well. We can indeed always refactor this later on if we wish, but swapping elements does seem a bit tricky to me too to get right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants