Skip to content
This repository has been archived by the owner on Dec 3, 2020. It is now read-only.

[Enhancement] "Price Wise" door hanger should respect the coloristics of the browser's dark theme #253

Open
SoftVision-CarmenFat opened this issue Nov 7, 2018 · 1 comment
Labels
[QA]:Enhancement Label for QA to mark enhancements logged

Comments

@SoftVision-CarmenFat
Copy link

[Affected versions]:

  • Firefox Release v63.0.1 and up

[Affected Platforms]:

  • All Windows
  • All Linux
  • All Mac

[Prerequisites]:

  • Have a Firefox profile with the latest version of the "Price Wise" add-on (9.0.0) downloaded from (download link).
  • The browser's theme is set to "Dark" from the about:addons "Themes" section

[Steps to reproduce]:

  1. Open the browser with the profile from prerequisites.
  2. Click the "Price Wise" toolbar button and observe the door hanger.

[Expected result]:

  • The door hanger respects the coloristics of the browser's dark theme

[Actual result]:

  • The door hanger doesn't respect the coloristics of the browser's dark theme

[Notes]:

  • Here is a screen shot of the issue:

dark theme

@SoftVision-CarmenFat SoftVision-CarmenFat added the [QA]:Enhancement Label for QA to mark enhancements logged label Nov 7, 2018
@Osmose
Copy link
Contributor

Osmose commented Nov 7, 2018

The present graphic would need to be redone for dark mode by design. Most of the rest of the icons and colors we can crib from the photon style guide and browser chrome.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[QA]:Enhancement Label for QA to mark enhancements logged
Projects
None yet
Development

No branches or pull requests

2 participants