Skip to content
This repository has been archived by the owner on Dec 3, 2020. It is now read-only.

Not able to add product to price wise, add button is grey #265

Closed
pdehaan opened this issue Nov 13, 2018 · 11 comments
Closed

Not able to add product to price wise, add button is grey #265

pdehaan opened this issue Nov 13, 2018 · 11 comments
Labels
[ENG]: Extraction Issues related to product extraction, including Fathom

Comments

@pdehaan
Copy link
Contributor

pdehaan commented Nov 13, 2018

via mozilla/testpilot#3983 /cc @BruceAWilliams

@pdehaan
Copy link
Contributor Author

pdehaan commented Nov 13, 2018

@BruceAWilliams: Which site were you trying to add a product from? (amazon.com? homedepot.com?, other?)

@koevskinikola
Copy link

Hey @pdehaan, are amazon.co.uk, amazon.es or amazon.de supported?

@Osmose
Copy link
Contributor

Osmose commented Nov 13, 2018

@BruceAWilliams As @pdehaan said, the full URL of the product you're trying to add is needed for us to debug the issue. Thank you!

@koevskinikola Only the US Amazon store is currently supported, so not being able to add products on those domains is expected.

@pdehaan
Copy link
Contributor Author

pdehaan commented Nov 13, 2018

@koevskinikola The full list of supported domains can be found at https://github.com/mozilla/price-wise/blob/00eaff21bad7d4875c195a53d4d798c5e8b185a3/src/state/vendors.js#L22-L53

@Osmose Osmose added the [ENG]: Triage Work the team needs to review to determine if it will be included as part of the next milestone. label Nov 13, 2018
@JenCant
Copy link

JenCant commented Nov 13, 2018

@BruceAWilliams As @pdehaan said, the full URL of the product you're trying to add is needed for us to debug the issue. Thank you!

@koevskinikola Only the US Amazon store is currently supported, so not being able to add products on those domains is expected.

I really think "US only" needs to be mentioned on the test pilot page - I just installed it assuming it would work with the UK site as it doesn't mention "US only" anywhere.

@saiyerniakhil
Copy link

Waiting for it to arrive in Other countries too

@jennajon
Copy link

Ditto on bug report of not being able to add items from Amazon USA.
Uninstalled, reinstalled and restarted FF-does not work
URL of item from Amazon USA: https://www.amazon.com/dp/B01EXQ0ZV0/?coliid=I3EGJ8X93UM2U9&colid=2ICW3SMNVOTL5&psc=0&ref_=lv_ov_lig_dp_it

@Osmose
Copy link
Contributor

Osmose commented Nov 14, 2018

I really think "US only" needs to be mentioned on the test pilot page - I just installed it assuming it would work with the UK site as it doesn't mention "US only" anywhere.

Excellent point, this is now being worked on in #266.

@Osmose
Copy link
Contributor

Osmose commented Nov 14, 2018

Ditto on bug report of not being able to add items from Amazon USA.
Uninstalled, reinstalled and restarted FF-does not work
URL of item from Amazon USA: https://www.amazon.com/dp/B01EXQ0ZV0/?coliid=I3EGJ8X93UM2U9&colid=2ICW3SMNVOTL5&psc=0&ref_=lv_ov_lig_dp_it

Ohh, I can actually replicate this. Interestingly, the page works when I'm logged in to Amazon, but when I'm not (or, at least, when I'm using private browsing mode), it doesn't. Thanks for the link!

I'm adding this to the pile of extraction issues; @erikrose and myself are working on these as a group currently, since they're all related to our ruleset and tooling for extracting product data.

@Osmose Osmose added [ENG]: Extraction Issues related to product extraction, including Fathom and removed [ENG]: Triage Work the team needs to review to determine if it will be included as part of the next milestone. labels Nov 14, 2018
@larrygiddens
Copy link

Likewise, I have a gray "add this product bar" on Walmart and Amazon, in normal and incognito mode. Here's the URL: https://www.amazon.com/PLAYMOBIL%C2%AE-5684-PLAYMOBIL-Pony-Farm/dp/B01B133YPC

@Osmose
Copy link
Contributor

Osmose commented Nov 20, 2018

This appears to have been fixed in #275 and should be fixed in v15.0.0 which has been released.

Thanks for the issue!

@Osmose Osmose closed this as completed Nov 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[ENG]: Extraction Issues related to product extraction, including Fathom
Projects
None yet
Development

No branches or pull requests

7 participants