Skip to content
This repository has been archived by the owner on Dec 3, 2020. It is now read-only.

Receiving notification of lower price BUT from used item #311

Open
Nehemoth opened this issue Apr 5, 2019 · 8 comments
Open

Receiving notification of lower price BUT from used item #311

Nehemoth opened this issue Apr 5, 2019 · 8 comments

Comments

@Nehemoth
Copy link

Nehemoth commented Apr 5, 2019

For some reason unknown I'm receiving notifications of lower price BUT this lower price it's for an used version of the item being tracked.

@biancadanforth
Copy link
Collaborator

Hi Nehemoth. Thanks for filing this issue. Our price extraction method can sometimes pull the wrong price, which I suspect may have happened here.

I'm planning to add an issue template in the near future, but in the meantime, could you provide a little more information on the following:

  • Your Firefox version
  • Your OS and version
  • Your version of Price Tracker
  • The URL for the product page that you were tracking using Price Tracker

Thanks again.

@Nehemoth
Copy link
Author

OMG, what an embarrassment, it looks like I'm getting old that I'm forgetting these first troubleshooting answers.
Anyway

Your Firefox version: Firefox Nightly 68.0a1 (being happening for weeks, don't remember it happens at home where I'm on release channel, will check).
Your OS and version: Windows 10 1709 (16299.1029)
Your version of Price Tracker: 22.0.0
The URL for the product page that you were tracking using Price Tracker

hxxps://www.amazon.com/gp/product/B00EHBERSE

Thank you for the reply

@biancadanforth
Copy link
Collaborator

Hi Nehemoth. Thanks for providing this extra information.

I tried this on a slightly newer version of Windows 10 (and on my Mac), and I only ever saw the "correct" price during a background update on this page.

Since our primary method of extraction is currently never being used due to a bug (see this comment), the extraction here is happening using our fallback extraction method of CSS selectors, which is not great.

When I inspect the page (on Nightly 68, Windows 10, Price Tracker v22), I see a span#usedPrice.a-size-base.a-color-secondary.header-price.a-text-normal element that I thought perhaps could be mistaken for the correct price, however, per our CSS selector source, we don't use that id or any combination of those class names as selection possibilities.

In general, CSS selectors are a brittle means of extracting product information from the page, and it is possible that the page itself has changed in between the time you saw the issue and now.

@Nehemoth
Copy link
Author

Not, the issue continues. I'd installed the Add-on at home when I'm on Release Channel and works like a charm but on Firefox Nightly the reflected price (sometimes I don't receive a notification) it's the one for the USED item.

Note: I'd deleted the Item and add it back later and the issue persist.

PD: Let me delete the item, restart Firefox and add it back.

@Nehemoth
Copy link
Author

Just restarted and added the item back, the reflected price it's the correct one right now, will track and return here again later.

Thank you for the follow up

@Nehemoth
Copy link
Author

Can confirm, still happens. The price was updated to the one for the Item Used.

@biancadanforth
Copy link
Collaborator

What is the exact value you are seeing that's incorrect (e.g. $10.00)? I searched for "item used" and "used item", and did not find any results on the page.

Also just to manage your expectations here, I just updated the README to this effect as well, but this project is no longer under active development.

What this means in this case is I will only be checking on things infrequently, and that I likely won't have time to dig deeply into issues unless they are of a critical nature (e.g. a security vulnerability).

@Nehemoth
Copy link
Author

Hi Bianca, I understand. Thank you anyway.

And just for answering the question, in the picture you can see in the red (at the bottom of the screen) the price that I see.

Price

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants