Skip to content
This repository has been archived by the owner on Dec 3, 2020. It is now read-only.

Send feedback button #104

Closed
Osmose opened this issue Sep 11, 2018 · 10 comments
Closed

Send feedback button #104

Osmose opened this issue Sep 11, 2018 · 10 comments
Assignees
Milestone

Comments

@Osmose
Copy link
Contributor

Osmose commented Sep 11, 2018

The product listing should have a "Send feedback" button at the bottom of the listing. When clicked, it should open a new tab to the feedback form (#59).

Styling of the button TBD. There is an open question about whether we should include information about the user's currently-tracked products with the link.

@Osmose Osmose added this to the November MVP milestone Sep 11, 2018
@Osmose
Copy link
Contributor Author

Osmose commented Sep 13, 2018

Button layout/position is in the design spec:

design_spec

Hover and active states for the button are in the photon design guidelines: https://design.firefox.com/photon/components/buttons.html

The extra data potentially sent to the feedback form will be filed as a new issue after #59 is resolved and we know what data we want to collect. For now the button can open any page, or about:blank.

@Osmose
Copy link
Contributor Author

Osmose commented Sep 17, 2018

Based on the Test Pilot feedback button guide, I'd like to suggest two changes to the current UX:

  1. We should include the "Send feedback" button in all states of the panel, including the onboarding state, rather than only showing it after the user has saved products.
  2. We should include their standard feedback icon to the left of the "Send Feedback" string, similar to how "Add This Product" has an icon.

@bryanbell That sound okay?

@bryanbell
Copy link

what's the "standard feedback icon?"

@Osmose
Copy link
Contributor Author

Osmose commented Sep 26, 2018

@bryanbell Specifically this SVG, with the same dark fill as the other icons we have: https://github.com/mozilla/testpilot/blob/master/docs/img/feedback/feedback-icon.svg

@Osmose Osmose self-assigned this Sep 26, 2018
@Osmose
Copy link
Contributor Author

Osmose commented Sep 26, 2018

WIP example:

screen shot 2018-09-26 at 2 10 39 pm

@Osmose
Copy link
Contributor Author

Osmose commented Sep 26, 2018

Chatted on Slack, we've decided to move the icon to the top left of the title bar so that we can have it in every view of the panel without distracting users from the "Watch this Product" button.

screen shot 2018-09-26 at 2 23 14 pm

Osmose pushed a commit that referenced this issue Sep 26, 2018
Osmose pushed a commit that referenced this issue Sep 26, 2018
@biancadanforth
Copy link
Collaborator

biancadanforth commented Sep 27, 2018

@Osmose, @bryanbell , The new location of the "Send Feedback" button is the same location as we were planning to put the loading GIF from issue #93 , is that okay? Would this mean the loading GIF would show on top of the feedback icon in cases where it is displayed?

@bryanbell
Copy link

I think superseding the feedback icon is reasonable, considering the loading times should be short.

But alternatively, we can also turn the "Add this product" button into a loader.
image

the icon can be the spinner, and the label can temporarily change to "Loading…".

@biancadanforth
Copy link
Collaborator

biancadanforth commented Sep 27, 2018

Thanks @bryanbell . I would vote for the former, since the loading GIF is supposed to be shown for both the extraction process and loading the tracked products list.

Edit: Also I keep calling it a GIF, when it is in fact a CSS animation of a single image...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants