Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn On / Off Swiper CSS / JS #2

Open
mread1208 opened this issue Sep 5, 2019 · 0 comments
Open

Turn On / Off Swiper CSS / JS #2

mread1208 opened this issue Sep 5, 2019 · 0 comments
Labels
enhancement New feature or request Hacktoberfest help wanted Extra attention is needed

Comments

@mread1208
Copy link
Owner

Currently, I'm enqueueing the CSS / JS as soon as you activate the plugin. But if the user's theme already includes the CSS and JS, then we would be including these files twice and bloating the site. There also could be version differences that would impact how this swiper works with other swipers on the page.

We should create an options page that allows the user to toggle on / off including the default CSS and JS for swiper and to use their own enqueued version instead. It would be a good idea to also have a message saying something to the affect of "This plugin was built for Swiper version x.x.x, using any other version may have unintended side effects and could cause the slider to not work properly. Proceed with caution".
@mread1208 mread1208 added enhancement New feature or request help wanted Extra attention is needed labels Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mread1208