-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Good practices/front end error handling #5
Conversation
@jherencia finally finished the proposal 😅 |
@hazzo Great work, I really like the approach. I do not have big concerns so I do not want to stop the process. I have doubts of Internal+External vs Known+Unknown, but I do not have a clear position and I think this should not stop anything. Go ahead! 💪 |
``` | ||
|
||
Also, we could benefit from UI frameworks implementations to capture and display these errors | ||
but this methods will help us better to handle **uncontrolled errors**. With these implementations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: these
### Network errors | ||
|
||
Network errors fall under the category of external errors and are the more common ones. | ||
Usually this errors are omitted, and they are partially caught by the language while |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: these
Usually this errors are omitted, and they are partially caught by the language while | ||
they bubble up and break some ui implementation. | ||
|
||
On an ideal scenario, this errors should be consciously caught and mapped to our |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: these
Great! So I'll merge and follow with the next task! |
Resolves first task of #4