Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Good practices/front end error handling #5

Merged
merged 6 commits into from
Jul 11, 2023

Conversation

hazzo
Copy link
Collaborator

@hazzo hazzo commented Jul 10, 2023

Resolves first task of #4

@hazzo hazzo added the good practices Mr. Milú "how to" good practice proposal label Jul 10, 2023
@hazzo hazzo requested a review from jherencia July 10, 2023 14:57
@hazzo
Copy link
Collaborator Author

hazzo commented Jul 10, 2023

@jherencia finally finished the proposal 😅
Let me know what you think, it's easier to read here: proposal

@jherencia
Copy link
Member

@hazzo Great work, I really like the approach.

I do not have big concerns so I do not want to stop the process. I have doubts of Internal+External vs Known+Unknown, but I do not have a clear position and I think this should not stop anything.

Go ahead! 💪

```

Also, we could benefit from UI frameworks implementations to capture and display these errors
but this methods will help us better to handle **uncontrolled errors**. With these implementations
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: these

### Network errors

Network errors fall under the category of external errors and are the more common ones.
Usually this errors are omitted, and they are partially caught by the language while
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: these

Usually this errors are omitted, and they are partially caught by the language while
they bubble up and break some ui implementation.

On an ideal scenario, this errors should be consciously caught and mapped to our
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: these

@hazzo
Copy link
Collaborator Author

hazzo commented Jul 11, 2023

@hazzo Great work, I really like the approach.

I do not have big concerns so I do not want to stop the process. I have doubts of Internal+External vs Known+Unknown, but I do not have a clear position and I think this should not stop anything.

Go ahead! 💪

Great! So I'll merge and follow with the next task!

@hazzo hazzo merged commit 6782856 into main Jul 11, 2023
@hazzo hazzo deleted the good_practices/front_end_error_handling branch July 11, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good practices Mr. Milú "how to" good practice proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants