Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few colors need improvement #113

Open
garrettw opened this issue Oct 16, 2017 · 4 comments
Open

A few colors need improvement #113

garrettw opened this issue Oct 16, 2017 · 4 comments

Comments

@garrettw
Copy link

I love the idea behind this, but after looking at the project's site, I see a few things I would change.

  1. Your red (#ff4136) looks more like the inside of a grapefruit than a true red. I'm not saying it should be #ff0000 at all, but it seems to have too much orange influence for a color merely called "red". Wikipedia even lists two colors on a page called "Shades of orange" (Tomato and Bittersweet) that are fairly close to your red.
  2. Your maroon (#85144b) is quite a departure from true maroon -- more like a burgundy. This webpage defines the two colors in the same way I would.
  3. If your black is not #000 (and I'm not saying it should be), then shouldn't your white similarly not be #fff? I probably wouldn't make it #eee, but I might do anything from #f8f8f8 to #fdfdfd.
@emilyford352
Copy link

Making a PR to fix these colors. Also realized the bigger issue is that it should be simpler to change the colors (they should be defined in one place, not in multiple files...). The colors should be defined in the variables file then every other file should reference those. I'll create a new issue/address that there. But for now I'll make a PR to fix the colors.

@emilyford352
Copy link

Making a PR to address the red/maroon issues. I personally think it's okay to leave the white at #fff. This shouldn't be an issue

@emilyford352
Copy link

#117

@elmarti
Copy link

elmarti commented Jun 24, 2018

Looks great, does anyone know of a way to easily check the red for AAA compliance, as there seems to be no compliant combinations for red in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants