-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contributors to project page #67
Comments
Such as a link to the contributors or the full list? |
@blainesch it would be nice to have something designed around the full content. Avatars / links to profile and such. Want to give credit where it's due :) |
@mrmrs would calling out to the jsonp callout to get the full list dynamically be a good approach or should this be static? For instance I could call this: Then with the new data put the user, avatar, and contribution count on the page. The only problem with this approach is there isn't currently any javascript on the page, and it might be easier to include a library for the ajax request and dom processing. The advantage is you'd never have to update the list. |
@blainesch I think doing it via the api is a great idea - but I think there is a middle ground that is best of both worlds. This is a super simple static page so I don't want to add any client side js that isn't needed. |
No description provided.
The text was updated successfully, but these errors were encountered: