Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributors to project page #67

Open
mrmrs opened this issue Jan 20, 2015 · 4 comments
Open

Add contributors to project page #67

mrmrs opened this issue Jan 20, 2015 · 4 comments
Assignees

Comments

@mrmrs
Copy link
Owner

mrmrs commented Jan 20, 2015

No description provided.

@mrmrs mrmrs changed the title Add contributors to project page. Add contributors to project page Jan 20, 2015
@mrmrs mrmrs self-assigned this Jan 20, 2015
@bayleedev
Copy link

Such as a link to the contributors or the full list?

@mrmrs
Copy link
Owner Author

mrmrs commented Dec 3, 2015

@blainesch it would be nice to have something designed around the full content. Avatars / links to profile and such. Want to give credit where it's due :)

@bayleedev
Copy link

@mrmrs would calling out to the jsonp callout to get the full list dynamically be a good approach or should this be static?

For instance I could call this:
https://api.github.com/repos/mrmrs/colors/contributors?callback=processDaytuh

Then with the new data put the user, avatar, and contribution count on the page.

The only problem with this approach is there isn't currently any javascript on the page, and it might be easier to include a library for the ajax request and dom processing. The advantage is you'd never have to update the list.

@mrmrs
Copy link
Owner Author

mrmrs commented Dec 4, 2015

@blainesch I think doing it via the api is a great idea - but I think there is a middle ground that is best of both worlds. This is a super simple static page so I don't want to add any client side js that isn't needed.
I think the best approach would be to use javascript to build out a static page - where we can just run an npm command to regenerate the static page. It still requires a little manual work - but I can live with that level of automation and we'd be able to keep the page lightweight. How does that approach sound to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants