Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignores the cache if required field exists but is falsy #14

Open
wildhart opened this issue Feb 7, 2020 · 0 comments
Open

Ignores the cache if required field exists but is falsy #14

wildhart opened this issue Feb 7, 2020 · 0 comments

Comments

@wildhart
Copy link

wildhart commented Feb 7, 2020

The return value of _getField() is usually defined by:

		if (!doc[field[i]]) {
			return; // === undefined
		}

and then the existance of the field is determined by:

if (typeof _getField(cache, item) === "undefined") {
  innocent = false;
}}

This will cause the cache to be missed if a required field exists but is falsy. E.g.:

doc = {admin: false}; // or null fails as well
field = 'admin';
_getField(doc, field); // undefined, the cache will be ignored :-(
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant