Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No module named 'typing_extensions' v4.5.0 #413

Closed
mathben opened this issue Jul 12, 2021 · 3 comments
Closed

No module named 'typing_extensions' v4.5.0 #413

mathben opened this issue Jul 12, 2021 · 3 comments

Comments

@mathben
Copy link

mathben commented Jul 12, 2021

   File "/usr/local/lib/python3.7/dist-packages/tinydb/__init__.py", line 27, in <module
     from .queries import Query, where
   File "/usr/local/lib/python3.7/dist-packages/tinydb/queries.py", line 28, in <module>
     from typing_extensions import Protocol
ModuleNotFoundError: No module named 'typing_extensions'

Running pip install typing_extensions fixed it. So this package is probably missing from the setup.py for version 4.5.0

@mathben mathben changed the title No module named 'typing_extensions' No module named 'typing_extensions' v4.5.0 Jul 12, 2021
@eugene-eeo
Copy link
Contributor

Yup -- there is no Protocol in Python 3.7's typing.
It was only added on Python 3.8.

@msiemens
Copy link
Owner

Oh, seems like this is by accident. I did consider this case and added typing_extensions as a dependency:

typing-extensions = { version = "^3.10.0", python = "<3.7" }

But as you can tell, I mistakenly used < instead of the correct <=. I'll publish a patch release today :)

@msiemens
Copy link
Owner

msiemens commented Jul 17, 2021

Version 4.5.1 has been pushed, the CI pipeline should publish the release in the next couple of minutes 🙂

EDIT: It's already published! Could you check if v4.5.1 correctly installs typing-extensions on Python 3.7?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants