Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Shaders Don't Work #1

Closed
msj121 opened this issue Nov 27, 2016 · 2 comments
Closed

Some Shaders Don't Work #1

msj121 opened this issue Nov 27, 2016 · 2 comments

Comments

@msj121
Copy link
Owner

msj121 commented Nov 27, 2016

The following shader doesn't work:

Enter_The_Matrix.json

Uncaught TypeError: Cannot read property 'x' of undefined(…)
s	@	three.js:31441
THREE.WebGLUniforms.U.upload	@	three.js:31820
b	@	three.js:26727
renderBufferDirect	@	three.js:25522
y	@	three.js:26289
render	@	three.js:26042
render	@	VREffect.js:376
value	@	a-scene.js:424
(anonymous function)	@	bind.js:12

https://rawgit.com/msj121/aframeFrogShaders/master/examples/error.html

@msj121 msj121 changed the title Shaders Don't Work Some Shaders Don't Work Nov 28, 2016
@donmccurdy
Copy link

FWIW, I've gotten this exact error when using a custom shader (e.g. AFRAME.registerShader(...)) because of doing something like:

{
  uniforms: {
    foo: new THREE.Vector3()
  }
}

instead of:

{
  uniforms: {
    foo: {value: new THREE.Vector3()}
  }
}

So I would guess that a uniform is being set incorrectly somewhere in the shaderfrog->threejs conversion.

@msj121
Copy link
Owner Author

msj121 commented Nov 28, 2016

Oh wow! Thanks for the heads up! This will hopefully narrow down my search for the code issue.

@msj121 msj121 closed this as completed Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants