You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
first things first, thanks for this library! 🙏 It has been very useful for multiple of my side projects.
While recently using the create feature for the first time I have been encountering a behavior which doesn't seem right. Here's how to reproduce it:
Set creatable to true and add createFilter={() => true} (always deny creating)
Provide a few valid options to Svelecte
Start searching for a valid option, select it using the arrow key and press Enter
My expectation would be that selecting any provided option would always work but the createFilter function seems to block it. Here's a REPL that contains an example to reproduce the issue.
I've already had a look at the code and identified that the issue is probably in this block of code as it doesn't check which option is currently selected and just prevents the selection if the createFilter returns true.
Just wanted to double check with you whether I'm missing something here. Let me know what you think. 🙂
The text was updated successfully, but these errors were encountered:
Yes, you're right. It's a bug, but it's not the only one I found when fixing. Therefore it will take more time. Hopefully tomorrow will have more time for it 🤞
Hey @mskocik,
first things first, thanks for this library! 🙏 It has been very useful for multiple of my side projects.
While recently using the create feature for the first time I have been encountering a behavior which doesn't seem right. Here's how to reproduce it:
createFilter={() => true}
(always deny creating)My expectation would be that selecting any provided option would always work but the createFilter function seems to block it.
Here's a REPL that contains an example to reproduce the issue.
I've already had a look at the code and identified that the issue is probably in this block of code as it doesn't check which option is currently selected and just prevents the selection if the createFilter returns true.
Just wanted to double check with you whether I'm missing something here. Let me know what you think. 🙂
The text was updated successfully, but these errors were encountered: