Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two different jest globals fixes documented in two places under https://mswjs.io/docs/ #2032

Closed
4 tasks done
jg210 opened this issue Feb 9, 2024 · 0 comments
Closed
4 tasks done
Labels
bug Something isn't working needs:triage Issues that have not been investigated yet. scope:node Related to MSW running in Node

Comments

@jg210
Copy link

jg210 commented Feb 9, 2024

Prerequisites

Environment check

  • I'm using the latest msw version
  • I'm using Node.js version 18 or higher

Node.js version

N/A

Reproduction repository

N/A

Reproduction steps

The online docs offer two different ways of solving problem of jest removing globals for fetch, Headers, Request, Response, FormData, Blob etc.:

https://mswjs.io/docs/faq#requestresponsetextencoder-is-not-defined-jest
https://mswjs.io/docs/runbook#fixing-environment

Current behavior

Two ways to solve one problem, documented in two places. I didn't find the runbook link at first.

Expected behavior

  • Pick one solution and use it in both places?
  • Mention both solutions in both places?
  • Merge FAQ and runbook pages?
  • Link to some checked-in jest config used by some msw automated tests, so can be more certain it works?
@jg210 jg210 added bug Something isn't working needs:triage Issues that have not been investigated yet. scope:node Related to MSW running in Node labels Feb 9, 2024
@mswjs mswjs locked and limited conversation to collaborators Feb 11, 2024
@kettanaito kettanaito converted this issue into discussion #2034 Feb 11, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
bug Something isn't working needs:triage Issues that have not been investigated yet. scope:node Related to MSW running in Node
Projects
None yet
Development

No branches or pull requests

1 participant