Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libplacebo-demos #19354

Closed
6 tasks done
kasper93 opened this issue Dec 13, 2023 · 4 comments · Fixed by #19355
Closed
6 tasks done

Add libplacebo-demos #19354

kasper93 opened this issue Dec 13, 2023 · 4 comments · Fixed by #19355

Comments

@kasper93
Copy link
Contributor

Package name

libplacebo-demos

Brief description of package

libplacebo, but the demo applications only. Main libplacebo package is a dependency of ffmpeg. We cannot build demos directly which depends on ffmpeg, creating dependency cycle as a result.

What I propose is to add libplacebo-demos package with only the demo applications.

Motivation is to give users ability to play around with those applications. Without forcing them to build locally, see haasn/libplacebo#231

URL for package's homepage

https://code.videolan.org/videolan/libplacebo

Provide a basic test case to validate the package's functionality.

No response

MINGW environments where you need the package

  • MINGW64
  • MINGW32
  • UCRT64
  • CLANG64
  • CLANG32
  • CLANGARM64

Are you willing to submit a PR?

No response

@Biswa96
Copy link
Member

Biswa96 commented Dec 13, 2023

It may be possible to add the demos. First, the libplacebo source need to be converted to git repository in PKGBUILD. Otherwise, the demos/3rdparty/nuklear does not exist in tarball and I got the linking error undefined reference to parse_args.

@Biswa96
Copy link
Member

Biswa96 commented Dec 13, 2023

Just realized that removing ffmpeg workarounds the issue as it does not compile plplay.

@kasper93
Copy link
Contributor Author

kasper93 commented Dec 13, 2023

alternatively it could be only plplay package, other demos are not that interesting IIRC.

@Biswa96
Copy link
Member

Biswa96 commented Dec 13, 2023

I have added a pull request to add the package. Would you like to test the packages from GitHub Actions artifacts of that pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants