Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

argument plot = FALSE or draw = FALSE #20

Open
timelyportfolio opened this issue Jul 28, 2015 · 3 comments
Open

argument plot = FALSE or draw = FALSE #20

timelyportfolio opened this issue Jul 28, 2015 · 3 comments

Comments

@timelyportfolio
Copy link
Collaborator

I dislike argument bloat, but based on d3treeR/d3treeR#12 from d3treeR, would it be possible to add an argument to skip the grid drawing piece in lines. Using the contrived example from d3treeR/d3treeR#12 with 4000 rows, here is the lineprof view.

image

I hesitate to even ask since treemap was designed for output, but would it be possible to add an argument to skip the plotting for use with d3treeR or other potential piggybacking packages?

@mtennekes
Copy link
Owner

Sure, no problem! Please try the latest version. It's a quick and dirty solution though: it still generates a grid.newpage(), with all its viewports. I cannot simply ignore that, since this also results in the aspect ratio that is needed to run the rectangle placement algorithm. A more elegant solution would be to let the desired aspect ratio be determined by the user in case draw=FALSE.

@timelyportfolio
Copy link
Collaborator Author

This is great. Sorry been really sick all week so just getting a chance to check it out. I'll use grid.grep to look for a legend in d3treeR so we know either a legend was not drawn or draw = FALSE. However, would it be worthwhile to add the value of draw in the invisibly returned list. Happy to submit pull if you would like.

@mtennekes
Copy link
Owner

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants