Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove replace directive for gosigar dependency #798

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

mintyleaf
Copy link
Contributor

@mintyleaf mintyleaf commented Nov 16, 2024

On arm64 MacOS machine i can't build the project with replaced mudler/[email protected]... package:

# github.com/elastic/gosigar
../../../go/pkg/mod/github.com/mudler/[email protected]/sigar_common_darwin.go:473:6: sysctlbyname redeclared in this block
	../../../go/pkg/mod/github.com/mudler/[email protected]/sigar_darwin.go:27:6: other declaration of sysctlbyname
../../../go/pkg/mod/github.com/mudler/[email protected]/sigar_common_darwin.go:71:19: method Swap.Get already declared at ../../../go/pkg/mod/github.com/mudler/[email protected]/sigar_darwin.go:57:19
../../../go/pkg/mod/github.com/mudler/[email protected]/sigar_common_darwin.go:86:27: method HugeTLBPages.Get already declared at ../../../go/pkg/mod/github.com/mudler/[email protected]/sigar_darwin.go:49:27
../../../go/pkg/mod/github.com/mudler/[email protected]/sigar_common_darwin.go:91:18: method Cpu.Get already declared at ../../../go/pkg/mod/github.com/mudler/[email protected]/sigar_darwin.go:65:18
../../../go/pkg/mod/github.com/mudler/[email protected]/sigar_common_darwin.go:32:26: method LoadAverage.Get already declared at ../../../go/pkg/mod/github.com/mudler/[email protected]/sigar_darwin.go:61:23
../../../go/pkg/mod/github.com/mudler/[email protected]/sigar_common_darwin.go:45:18: method Mem.Get already declared at ../../../go/pkg/mod/github.com/mudler/[email protected]/sigar_darwin.go:45:18
../../../go/pkg/mod/github.com/mudler/[email protected]/sigar_common_darwin.go:167:22: method FDUsage.Get already declared at ../../../go/pkg/mod/github.com/mudler/[email protected]/sigar_darwin.go:53:22

removing replace directive and using upstream gosigar working flawlessly.

Copy link
Owner

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! good to know that now gosigar builds against darwin!

@mudler mudler enabled auto-merge (squash) November 18, 2024 13:51
@mudler mudler merged commit 93380e5 into mudler:master Nov 18, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants