Handle crashing of .scrollIntoView on Firefox 52-57 (#1393)

* Handle crashing of .scrollIntoView on Firefox 52-57 * Still call scrollIntoView if throws exception with parameters
mui · Nov 15, 2019 · 66074f3 · 66074f3
1 parent 053c069
commit 66074f3
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/lib/src/views/Year/YearView.tsx b/lib/src/views/Year/YearView.tsx
@@ -44,10 +44,15 @@ export const YearSelection: React.FC<YearSelectionProps> = ({
 
   React.useEffect(() => {
     if (selectedYearRef.current && selectedYearRef.current.scrollIntoView) {
-      selectedYearRef.current.scrollIntoView({
-        block: currentVariant === 'static' ? 'nearest' : 'center',
-        behavior: animateYearScrolling ? 'smooth' : 'auto',
-      });
+      try {
+        selectedYearRef.current.scrollIntoView({
+          block: currentVariant === 'static' ? 'nearest' : 'center',
+          behavior: animateYearScrolling ? 'smooth' : 'auto',
+        });
+      } catch (e) {
+        // call without arguments in case when scrollIntoView works improperly (e.g. Firefox 52-57)
+        selectedYearRef.current.scrollIntoView();
+      }
     }
   }, []); // eslint-disable-line