[Drawer] Change height from 100vh to 100% #12528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
oliviertassinari
changed the title
oliviertassinari
added
new feature
|
@joemaffei It's a great first pull request on Material-UI 👌🏻. Thank you for giving it a shot! |
This was referenced Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in issue #12285, mobile Safari has a unique interpretation of
100vh, which includes the space behind the button bar. This can cause elements to be hidden behind the button bar, especially ones that are anchored to the bottom of the Drawer, as is common with buttons and links.A value of
100%behaves as expected, occupying the full height of the visible area - not only in mobile Safari, but all other browsers to my knowledge.Closes #12285