[Pagination] Introduce new component #19049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrookes
added
the
component: pagination
konekoya
reviewed
Dec 31, 2019
oliviertassinari
changed the title
There was a problem hiding this comment.
It's awesome to see the pagination component taking shape :)!
I have tried to focus the review on what's already implemented and not what's missing as it's a draft. I have updated #18449 (comment) with more items I think are important to complete the first batch, e.g. responsive handling.
- Once we document the integration with react-router, I think that we should share somewhere that -
/routeshould be preferred over/route?page=1from an SEO perspective, it avoids one-page craw. - Something is not right with the style of the outlined disabled items. They are more "visible" than the outlined active items. I believe disabled items should fade behind the active ones.
- For the prop types, if we can get the autogeneration from the TypeScript definitions, it will be perfect.
@szmslab, @iRyanBell given your past interest in the component, we would love to get your feedback on it, before it gets into the lab, and hopefully, in the core.
mbrookes
force-pushed
the
pagination
branch
4 times, most recently
from
366caf2 to
3a882dc
Compare
docs/src/pages/components/pagination/PaginationOutlinedRounded.tsx
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
mbrookes
force-pushed
the
pagination
branch
2 times, most recently
from
46081cd to
8cbc072
Compare
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Joshua <[email protected]>
# Conflicts: # yarn.lock
eps1lon
reviewed
Feb 4, 2020
Co-Authored-By: Sebastian Silbermann <[email protected]>
oliviertassinari
approved these changes
Feb 7, 2020
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Feb 13, 2020
This was referenced Mar 10, 2020
This was referenced Mar 21, 2020
This was referenced Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://deploy-preview-19049--material-ui.netlify.com/components/pagination/.
Closes #18449
No tests (to follow once the API is stable)Some tests