Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix /versions GitHub API rate limitation #19223

Merged
merged 3 commits into from
Jan 27, 2020
Merged

[docs] Fix /versions GitHub API rate limitation #19223

merged 3 commits into from
Jan 27, 2020

Conversation

hiteshkundal
Copy link
Contributor

@hiteshkundal hiteshkundal commented Jan 14, 2020 •
edited
Loading

Resolves #14762

Before 😧

Screenshot 2020-01-14 at 8 26 44 PM

After 😎

Screenshot 2020-01-14 at 10 33 08 PM

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 14, 2020 •
edited
Loading

Details of bundle changes.

Comparing: 109c763...c072143

bundle Size Change Size Gzip Change Gzip
docs.main ▲ +12 B (0.00% ) 595 kB ▲ +8 B (0.00% ) 194 kB
@material-ui/core -- 360 kB -- 98.7 kB
@material-ui/core[umd] -- 317 kB -- 91.9 kB
@material-ui/lab -- 185 kB -- 55.2 kB
@material-ui/styles -- 51.2 kB -- 15.4 kB
@material-ui/system -- 14.8 kB -- 4.07 kB
Alert -- 83.8 kB -- 26.3 kB
AlertTitle -- 64.2 kB -- 20.2 kB
AppBar -- 63.9 kB -- 20 kB
Autocomplete -- 132 kB -- 41.3 kB
Avatar -- 65.2 kB -- 20.6 kB
AvatarGroup -- 62.3 kB -- 19.6 kB
Backdrop -- 67.9 kB -- 21 kB
Badge -- 65.3 kB -- 20.4 kB
BottomNavigation -- 62.4 kB -- 19.6 kB
BottomNavigationAction -- 75.6 kB -- 23.9 kB
Box -- 70.9 kB -- 21.6 kB
Breadcrumbs -- 67.8 kB -- 21.3 kB
Button -- 79.8 kB -- 24.5 kB
ButtonBase -- 74 kB -- 23.3 kB
ButtonGroup -- 83.3 kB -- 25.5 kB
Card -- 62.9 kB -- 19.7 kB
CardActionArea -- 75.1 kB -- 23.7 kB
CardActions -- 62 kB -- 19.5 kB
CardContent -- 62 kB -- 19.4 kB
CardHeader -- 65.1 kB -- 20.5 kB
CardMedia -- 62.3 kB -- 19.6 kB
Checkbox -- 83 kB -- 26.3 kB
Chip -- 82.6 kB -- 25.4 kB
CircularProgress -- 64.1 kB -- 20.3 kB
ClickAwayListener -- 3.91 kB -- 1.55 kB
Collapse -- 68 kB -- 21.1 kB
colorManipulator -- 3.88 kB -- 1.52 kB
Container -- 63.3 kB -- 19.8 kB
CssBaseline -- 57.5 kB -- 18.1 kB
Dialog -- 83.1 kB -- 25.9 kB
DialogActions -- 62.1 kB -- 19.5 kB
DialogContent -- 62.2 kB -- 19.5 kB
DialogContentText -- 64 kB -- 20.2 kB
DialogTitle -- 64.3 kB -- 20.2 kB
Divider -- 62.6 kB -- 19.7 kB
docs.landing -- 50.5 kB -- 13.2 kB
Drawer -- 84.8 kB -- 25.8 kB
ExpansionPanel -- 72.3 kB -- 22.7 kB
ExpansionPanelActions -- 62.1 kB -- 19.5 kB
ExpansionPanelDetails -- 61.9 kB -- 19.4 kB
ExpansionPanelSummary -- 78.2 kB -- 24.7 kB
Fab -- 76.9 kB -- 24 kB
Fade -- 23.4 kB -- 7.98 kB
FilledInput -- 73.6 kB -- 22.9 kB
FormControl -- 64.4 kB -- 20.1 kB
FormControlLabel -- 65.5 kB -- 20.6 kB
FormGroup -- 62 kB -- 19.5 kB
FormHelperText -- 63.3 kB -- 19.9 kB
FormLabel -- 63.5 kB -- 19.7 kB
Grid -- 65.1 kB -- 20.4 kB
GridList -- 62.5 kB -- 19.7 kB
GridListTile -- 63.7 kB -- 20 kB
GridListTileBar -- 63.2 kB -- 19.8 kB
Grow -- 24 kB -- 8.19 kB
Hidden -- 66 kB -- 20.7 kB
Icon -- 62.8 kB -- 19.7 kB
IconButton -- 76.2 kB -- 23.8 kB
Input -- 72.5 kB -- 22.7 kB
InputAdornment -- 65.1 kB -- 20.5 kB
InputBase -- 70.6 kB -- 22.2 kB
InputLabel -- 65.3 kB -- 20.2 kB
LinearProgress -- 65.3 kB -- 20.4 kB
Link -- 66.6 kB -- 21.1 kB
List -- 62.4 kB -- 19.5 kB
ListItem -- 77.2 kB -- 24.2 kB
ListItemAvatar -- 62.1 kB -- 19.5 kB
ListItemIcon -- 62.2 kB -- 19.5 kB
ListItemSecondaryAction -- 62 kB -- 19.5 kB
ListItemText -- 65 kB -- 20.4 kB
ListSubheader -- 62.8 kB -- 19.8 kB
Menu -- 88.8 kB -- 27.4 kB
MenuItem -- 78.2 kB -- 24.5 kB
MenuList -- 66 kB -- 20.7 kB
MobileStepper -- 67.8 kB -- 21.3 kB
Modal -- 14.5 kB -- 5.05 kB
NativeSelect -- 76.9 kB -- 24.3 kB
NoSsr -- 2.19 kB -- 1.04 kB
OutlinedInput -- 74.6 kB -- 23.2 kB
Paper -- 62.4 kB -- 19.5 kB
Popover -- 83.1 kB -- 25.8 kB
Popper -- 28.8 kB -- 10.3 kB
Portal -- 2.92 kB -- 1.3 kB
Radio -- 84.1 kB -- 26.5 kB
RadioGroup -- 64.5 kB -- 20 kB
Rating -- 70.5 kB -- 22.7 kB
RootRef -- 4.24 kB -- 1.64 kB
Select -- 116 kB -- 34.6 kB
Skeleton -- 62.9 kB -- 19.9 kB
Slide -- 25.5 kB -- 8.71 kB
Slider -- 76.6 kB -- 24.3 kB
Snackbar -- 75.4 kB -- 23.6 kB
SnackbarContent -- 63.5 kB -- 20 kB
SpeedDial -- 86.3 kB -- 27.2 kB
SpeedDialAction -- 118 kB -- 37.5 kB
SpeedDialIcon -- 64.6 kB -- 20.3 kB
Step -- 62.7 kB -- 19.7 kB
StepButton -- 82.4 kB -- 26.1 kB
StepConnector -- 62.7 kB -- 19.8 kB
StepContent -- 69.2 kB -- 21.7 kB
StepIcon -- 64.6 kB -- 20.2 kB
StepLabel -- 68.6 kB -- 21.7 kB
Stepper -- 64.9 kB -- 20.5 kB
styles/createMuiTheme -- 16.5 kB -- 5.81 kB
SvgIcon -- 63 kB -- 19.7 kB
SwipeableDrawer -- 92.3 kB -- 28.9 kB
Switch -- 82.2 kB -- 25.9 kB
Tab -- 76.4 kB -- 24.2 kB
Table -- 62.6 kB -- 19.7 kB
TableBody -- 62.1 kB -- 19.5 kB
TableCell -- 64 kB -- 20.2 kB
TableContainer -- 62 kB -- 19.4 kB
TableFooter -- 62.1 kB -- 19.5 kB
TableHead -- 62.1 kB -- 19.5 kB
TablePagination -- 143 kB -- 41.9 kB
TableRow -- 62.5 kB -- 19.6 kB
TableSortLabel -- 77.5 kB -- 24.4 kB
Tabs -- 85.7 kB -- 27.2 kB
TextareaAutosize -- 5.12 kB -- 2.14 kB
TextField -- 125 kB -- 36.6 kB
ToggleButton -- 76.2 kB -- 24.1 kB
ToggleButtonGroup -- 63.2 kB -- 19.9 kB
Toolbar -- 62.3 kB -- 19.6 kB
Tooltip -- 102 kB -- 32.3 kB
TreeItem -- 74 kB -- 23.4 kB
TreeView -- 66.7 kB -- 21 kB
Typography -- 63.7 kB -- 20 kB
useAutocomplete -- 14.6 kB -- 5.27 kB
useMediaQuery -- 2.51 kB -- 1.06 kB
Zoom -- 23.5 kB -- 8.1 kB

Generated by 🚫 dangerJS against c072143

@hiteshkundal hiteshkundal changed the title [docs] /versions page rate limited issue with GitHub API [GitHub] /versions page rate limited issue with GitHub API Jan 14, 2020
@hiteshkundal hiteshkundal changed the title [GitHub] /versions page rate limited issue with GitHub API [docs] /versions page rate limited issue with GitHub API Jan 14, 2020
@hiteshkundal hiteshkundal marked this pull request as ready for review January 14, 2020 10:52
oliviertassinari
oliviertassinari reviewed Jan 14, 2020
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a feature perspective, it seems to work great: https://deploy-preview-19223--material-ui.netlify.com/versions/. Great start! :)

docs/src/pages/versions/StableVersions.js Outdated Show resolved Hide resolved
docs/pages/versions.js Outdated Show resolved Hide resolved
docs/pages/_app.js Outdated Show resolved Hide resolved
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jan 14, 2020
@oliviertassinari oliviertassinari changed the title [docs] /versions page rate limited issue with GitHub API [docs] Fix /versions GitHub API rate limitation Jan 14, 2020
@oliviertassinari oliviertassinari added the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Jan 14, 2020
@hiteshkundal
[fix]: Review change
7685129 
- Remove version props from global and use context api instead of that.
- Remove useEffect from StableVersion.js
- Remove cachebranch variable from global scope
@hiteshkundal
Copy link
Contributor Author

@oliviertassinari I couldn't find why argos is failing.

@mbrookes mbrookes removed the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Jan 14, 2020
@mbrookes
Copy link
Member

I couldn't find why argos is failing

It's catching a mobile-stepper image size change, but it isn't related to this PR.

@hiteshkundal hiteshkundal reopened this Jan 14, 2020
@mui mui deleted a comment from hiteshkundal Jan 14, 2020
@hiteshkundal

This comment has been minimized.

Sign in to view
@oliviertassinari oliviertassinari added PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed PR: ready to ship labels Jan 14, 2020
@oliviertassinari oliviertassinari added PR: ready to ship and removed PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Jan 27, 2020
oliviertassinari
oliviertassinari approved these changes Jan 27, 2020
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hiteshkundal As you mentioned that you didn't have the time to complete the effort before some time, I went ahead with a small commit. I believe we are good to go. Thanks for the help!

@oliviertassinari oliviertassinari merged commit cbe079c into mui:master Jan 27, 2020
EsoterikStare pushed a commit to EsoterikStare/material-ui that referenced this pull request Feb 13, 2020
@hiteshkundal @EsoterikStare
[docs] Fix /versions GitHub API rate limitation (mui#19223)
0895d6f
This was referenced Feb 25, 2020
Closed
Merged
Merged
This was referenced Mar 10, 2020
Merged
Merged
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 22, 2020
Open
This was referenced Apr 16, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon left review comments

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@mbrookes mbrookes mbrookes approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs] /versions page rate limited issue with GitHub API
5 participants
@hiteshkundal @mui-pr-bot @mbrookes @oliviertassinari @eps1lon