Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] cross-os jsonlint #19377

Merged
merged 2 commits into from
Jan 26, 2020
Merged

[core] cross-os jsonlint #19377

merged 2 commits into from
Jan 26, 2020

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jan 24, 2020

Removes jsonlint in favor of JSON.parse

Main selling point is point 3. tsconfigs are not compliant JSON files. They can contain comments which is important for reasonable configuration files. See #19375

  1. loose nice error messages (or rather requires extra step by pasting content into jsontlint.com
  2. add cross-os support
  3. more readable file selection which would otherwise require large scripts entries
  4. see list of files directly in console (and therefore CI) to spot potential issues

@eps1lon eps1lon added new feature New feature or request worktree labels Jan 24, 2020
@eps1lon eps1lon force-pushed the chore/cross-os-jsonlint branch from 8a7c288 to d655ae1 Compare January 24, 2020 12:00
@mui-pr-bot
Copy link

mui-pr-bot commented Jan 24, 2020 •
edited
Loading

No bundle size changes comparing 0177cd6...54c4613

Generated by 🚫 dangerJS against 54c4613

@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 26, 2020 •
edited
Loading

jsonlint definitely seems to be unmaintained.

@oliviertassinari oliviertassinari merged commit 0183d4c into mui:master Jan 26, 2020
@oliviertassinari
Copy link
Member

👌

@eps1lon eps1lon deleted the chore/cross-os-jsonlint branch January 26, 2020 19:34
EsoterikStare pushed a commit to EsoterikStare/material-ui that referenced this pull request Feb 13, 2020
@eps1lon @EsoterikStare
[core] cross-os jsonlint (mui#19377)
aee6cf8
This was referenced Feb 25, 2020
Closed
Merged
Merged
This was referenced Mar 10, 2020
Merged
Merged
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 22, 2020
Open
This was referenced Apr 16, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eps1lon @mui-pr-bot @oliviertassinari