[core] Batch small changes #19416
Merged
[core] Batch small changes #19416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
oliviertassinari
commented
Jan 26, 2020
•
oliviertassinari
commented
- [docs] Use style root convention 20cd5cb: further increase the consistency of the codebase. found investigating an issue.
- [docs] Fix wrong social share logo URL da8c3d5: our logo was no longer displayed when a link of the documentated is shared on Twitter, Slack, etc.
- [docs] Fix Autocomplete reason description 8fd78f3: further increase the consistency of the codebase. found investigating an issue.
- [core] Prefer early export default for consistency 143e908: further increase the consistency of the codebase. found investigating an issue.
- [TablePagination] Remove select icon override a477ec8: likely not needed. found investigating an issue.
- [test] Ignore flaky TextMobileStepper dcdabbe: this flaky test has been a pain.
- [ButtonBase] Remove intermediary component 283d5da: The button component is quite scarying when inspected with the DevTool, it's one less layer :). found investigating an issue.
- [docs] Fix Autocomplete demo on Safari 536c3c0: thank safari for the default margin. found investigating an issue.
- [docs] Polish typography demos 622a00c.
- [core] Normalize list style reset 82ecb91: further increase the consistency of the codebase. found investigating an issue.
- [docs] Avoid layout jump 9fd33cc: can be noticed on the installation page. found investigating an issue.
- [design] Link the Sketch version 2ab33ab: yay, it's live. also take the time to try different wordings.
- [Skeleton] Make demo Facebook closer to the original 19c2ba9: something I should have done in the first place when introducing the wave animation. Somebody recently reported an issue with the dark mode, I didn't want to take care of it here.
oliviertassinari
added
the
umbrella
Wrong commit message? |
joshwooding
reviewed
Jan 27, 2020
|
I need to fix the visual regression and I have a couple more coming.
@mbrookes It doesn't seem that we need to apply a top: 1 style.
|
oliviertassinari
force-pushed
the
batch-small-changes-v22
branch
from
5049d87 to
19c2ba9
Compare
Details of bundle changes.Comparing: 15d182c...74bc5b3
|
|
I missed it amongst all the unrelated changes. |
Until we fix CssBasline to apply body1 by default and not body2 on the body element in v5 we need to apply the style here. The smaller line height is especially concerninng.
mbrookes
previously requested changes
Jan 29, 2020
| @@ -53,7 +53,15 @@ const inHouseAds = [ | |||
| name: 'scaffoldhub', | |||
| link: 'https://scaffoldhub.io/?partner=1', | |||
| img: '/static/in-house/scaffoldhub.png', | |||
| description: '<b>ScaffoldHub</b> - Automate building your full-stack Material-UI web-app.', | |||
| description: '<b>Scaffold</b><br />Automate building your full-stack Material-UI web-app.', | |||
There was a problem hiding this comment.
Suggested change
| description: '<b>Scaffold</b><br />Automate building your full-stack Material-UI web-app.', | |
| description: '<b>ScaffoldHub</b><br />Automate building your full-stack Material-UI web-app.', |
There was a problem hiding this comment.
The logo is branded, I wanted to cover the generic noun. What do you think?
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Feb 13, 2020
This was referenced Mar 10, 2020
This was referenced Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.