-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autocomplete] Update docs for defaultValue prop #19431
Conversation
Details of bundle changes.Comparing: cbe079c...a81d185
|
@willwill96 Thanks. Regarding the controllable behavior of the component, does it make more sense now why it doesn't behave as you expected? What did you think of the idea to have a dedicated documentation subsection for the controllable aspect? |
@oliviertassinari Yes, it makes a lot more sense now why I was seeing unexpected results. I think a dedicated subsection for the controllable aspect of the component would do a lot to clear up confusion. I still think I would argue though, that the |
Thanks for the feedback. There is an important distinction to make: developers don't control a component but a state. We have a couple of more cases in the codebase. The DataGrid will be a great example. It's not because you control the state of the active page that you want to control the state of the sorting. The same applies here. Yeap, we can try a new section to close the linked issue. I'm merging as it's already a good step. |
Link to source of issue: #19423 (comment)
default value of defaultValue is not currently being documented