Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] makeStyles doesn't have access to the component's name #19474

Merged
merged 1 commit into from
Feb 1, 2020
Merged

[docs] makeStyles doesn't have access to the component's name #19474

merged 1 commit into from
Feb 1, 2020

Conversation

hesto2
Copy link
Contributor

@hesto2 hesto2 commented Jan 29, 2020 •
edited by oliviertassinari
Loading

Closes #19459

@hesto2 hesto2 requested a review from eps1lon January 30, 2020 00:00
@mui-pr-bot
Copy link

No bundle size changes comparing 5c84559...fdbfeb9

Generated by 🚫 dangerJS against fdbfeb9

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jan 30, 2020
@oliviertassinari oliviertassinari changed the title updated documentation per: https://github.com/mui-org/material-ui/iss… [docs] makeStyles doesn't have access to the component's name Jan 30, 2020
@oliviertassinari oliviertassinari merged commit 2bec1ce into mui:master Feb 1, 2020
@oliviertassinari
Copy link
Member

Thank you

EsoterikStare pushed a commit to EsoterikStare/material-ui that referenced this pull request Feb 13, 2020
@hesto2 @EsoterikStare
[docs] makeStyles doesn't have access to the component's name (mui#19474
1cd8a5d 
)
This was referenced Feb 25, 2020
Closed
Merged
Merged
This was referenced Mar 10, 2020
Merged
Merged
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 22, 2020
Open
This was referenced Apr 16, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@eps1lon eps1lon Awaiting requested review from eps1lon

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

makeStyles does not use component name if no name option is provided.
3 participants
@hesto2 @mui-pr-bot @oliviertassinari