-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[InputBase] Declare global mui-auto-fill(-cancel) keyframes #19497
Merged
oliviertassinari
merged 2 commits into
mui:master
from
martinjlowm:fix-input-base-with-disable-global
Feb 1, 2020
Merged
[InputBase] Declare global mui-auto-fill(-cancel) keyframes #19497
oliviertassinari
merged 2 commits into
mui:master
from
martinjlowm:fix-input-base-with-disable-global
Feb 1, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: ac5c1ae...cf1a64e
|
martinjlowm
force-pushed
the
fix-input-base-with-disable-global
branch
from
January 31, 2020 13:45
4459b2f
to
1fdaa03
Compare
|
Browser autofill workaround logic requires static animation name references for keyframes. Enabling disableGlobal renames such keyframes unless they are marked as global.
martinjlowm
force-pushed
the
fix-input-base-with-disable-global
branch
from
January 31, 2020 15:40
daedb3b
to
0387d86
Compare
martinjlowm
force-pushed
the
fix-input-base-with-disable-global
branch
from
January 31, 2020 16:33
0387d86
to
cf1a64e
Compare
oliviertassinari
approved these changes
Jan 31, 2020
oliviertassinari
added
component: text field
This is the name of the generic UI component, not the React module!
PR: ready to ship
bug 🐛
Something doesn't work
labels
Jan 31, 2020
@martinjlowm It's a great first pull request on Material-UI 👌🏻. Thank you for working on it! |
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Feb 13, 2020
This was referenced Mar 10, 2020
This was referenced Apr 16, 2020
This was referenced Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
component: text field
This is the name of the generic UI component, not the React module!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browser autofill workaround logic requires static animation name references for
keyframes. Enabling disableGlobal renames such keyframes unless they are marked
as global.
Fixes #19224
This also disables class documentation for
@global
identifiers (assuming that is okay).