[docs] Improve entry points for issue repros #19501
Conversation
eps1lon
added
docs
|
No bundle size changes comparing 5a2fd6a...4da57d4 |
There was a problem hiding this comment.
- It seems that we can use our GitHub slug for invites, does it work with "oliviertassinari"?
- For this template: https://codesandbox.io/s/material-ui-issue-dh2yh, should we expose the ThemeProvider? Sometimes it's useful to showcase an issue with the theme, but I wonder, it's not very frequent either.
- What're tradeoff (pros/cons) of the template vs polling the CRA example?
|
|
||
| If YOU DO NOT take time to provide a codesandbox.io reproduction, should the COMMUNITY take time to help you? | ||
| Issues without some form of live example have a longer response time. |
There was a problem hiding this comment.
😆
| Issues without some form of live example have a longer response time. | |
| Issues without some form of live example will be ignored and closed. |
There was a problem hiding this comment.
If I'm moody, yes ;) I would introduce a "missing reproduction" label and close these if they have that label for 7 days.
There was a problem hiding this comment.
What about the incomplete label, and close with this message?
The issue has been closed because it does not conform to our issue requirements.
Please provide a full reproduction test case. This would help a lot 👷 .
A live example would be perfect. This codesandbox.io template may be a good starting point. Thank you!
There was a problem hiding this comment.
Yep and then use the issue template instead of the example.
Different goals: One showcases example usage, the other is a base for an issue. In one you have a sandbox where you can delete things. You shouldn't delete anything from the template.
Invite sent.
Not every issue uses the provider. In most issues it would be just noise. |
Co-Authored-By: Kristoffer K. <[email protected]>
Co-authored-by: Kristoffer K. <[email protected]>
Ready for review though not mergable. ~I want to fix/improve the TypeScript playground experience first (since it doesn't support
@material-ui/core/Typographyyet). ~ Involves too much work. Would like to see microsoft/TypeScript-Website#206 get fixed at some point though.Opening to get feedback about the wording.
Recommended codesandbox for repros is now a dedicated codesandbox template that is owned by the team (need your names for invite).