[docs] The error style rule is a pseudo-class #19555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TommyJackson85
changed the title
|
No bundle size changes comparing 21e9f1d...b64fcb2 |
|
@TommyJackson85 Could you fix the CI :)? |
oliviertassinari
changed the title
oliviertassinari
added
component: text field
oliviertassinari
changed the title
|
@oliviertassinari from running `yarn lint:ci`
```yarn lint:ci
yarn run v1.16.0
$ eslint . --report-unused-disable-directives
/Users/thomasjackson/Desktop/Software projects/Open Source Projects/material-ui/docs/src/modules/components/AdInHouse.js
1:1 error Configuration for rule "react/jsx-no-target-blank" is invalid:
Value {"allowReferrer":true} should NOT have additional properties.
react/jsx-no-target-blank
54:9 error Using target="_blank" without rel="noopener noreferrer" is a security risk: see https://mathiasbynens.github.io/rel-noopener react/jsx-no-target-blank
/Users/thomasjackson/Desktop/Software projects/Open Source Projects/material-ui/packages/babel-plugin-unwrap-createstyles/test/unwrapCreateStyles.test.js
1:26 error Unable to resolve path to module 'babel-plugin-tester/pure' import/no-unresolved
✖ 3 problems (3 errors, 0 warnings)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.```
Is this why it's broken?
Managed to remove the first error (1:1) by changing it to an empty object instead `{}`
Would removing target="_blank" and rel="noopener noreferrer" fix the next?
Unsure if these changes are recommended in the long run and might cause other errors, unless you can tell me otherwise.
Will keep updating this comment when ever I make changes.
… On 4 Feb 2020, at 17:33, Olivier Tassinari ***@***.***> wrote:
@TommyJackson85 Could you fix the CI :)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
@TommyJackson85 Try 1. upgrading yarn to a more recent version 2. running a new install.
|
Reinstalled yarn and ran yarn docs:api to try and fix cicircle fail and other fails. |
joshwooding
approved these changes
Feb 5, 2020
|
It looks great. Well done. |
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Feb 13, 2020
This was referenced Mar 10, 2020
This was referenced Mar 21, 2020
This was referenced Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19551
Changed text description for styles applied on errors, from "Styles" to "Pseudo Class".