-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Export TypographyVariant type #19598
[core] Export TypographyVariant type #19598
Conversation
- export useful TS types for typography which were hard to discover - Remove unused code
No bundle size changes comparing 01b8b09...1ed5965 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Form how I understood it, the idea what to expose more variables from createMuiTheme, for instance, the ones we import deep in https://material-ui.com/guides/typescript/? I don't understand why the types of the Typography component needs to be changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this but this is not what we discussed in #19572. It was specifically about createTypography
and generally about key types that can't be extracted.
|
||
export interface TypographyTypeMap<P = {}, D extends React.ElementType = 'span'> { | ||
props: P & { | ||
align?: PropTypes.Alignment; | ||
align?: TypographyAlignment; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this as explained in #19572 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, will do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eps1lon fixed
@oliviertassinari Ah i defiantly misunderstood that, but can do that if you would like. Would you want me to just import/export them straight from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We were discussing Variant
in createTypography
not Typography
. I can see no issue with Typography
. Please stick to the things we discussed in the issue.
@aleccaputo Did you have the time to look at the issue? :) |
@oliviertassinari @eps1lon how's that look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks!
@aleccaputo Thank you for the cooperation! |
for feature #19572
Closes #19572