Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] What's the lab about? #19611

Merged
merged 5 commits into from
Feb 10, 2020

Conversation

jcafiero
Copy link
Contributor

@jcafiero jcafiero commented Feb 7, 2020

Closes #19448

@mui-pr-bot
Copy link

mui-pr-bot commented Feb 7, 2020

No bundle size changes comparing 3f823dc...18d4337

Generated by 🚫 dangerJS against 18d4337

@mbrookes mbrookes changed the title Docs update about lab [docs] Update "About the lab" page Feb 7, 2020
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Feb 7, 2020
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the lead on this

docs/src/pages/components/about-the-lab/about-the-lab.md Outdated Show resolved Hide resolved
docs/src/pages/components/about-the-lab/about-the-lab.md Outdated Show resolved Hide resolved
@oliviertassinari oliviertassinari changed the title [docs] Update "About the lab" page [docs] What's the lab about? Feb 7, 2020
Copy link
Member

@mbrookes mbrookes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oliviertassinari I've tweaked some of your suggested changes, and added a few more.

docs/src/pages/components/about-the-lab/about-the-lab.md Outdated Show resolved Hide resolved
docs/src/pages/components/about-the-lab/about-the-lab.md Outdated Show resolved Hide resolved
docs/src/pages/components/about-the-lab/about-the-lab.md Outdated Show resolved Hide resolved
docs/src/pages/components/about-the-lab/about-the-lab.md Outdated Show resolved Hide resolved
docs/src/pages/components/about-the-lab/about-the-lab.md Outdated Show resolved Hide resolved
docs/src/pages/components/about-the-lab/about-the-lab.md Outdated Show resolved Hide resolved
@oliviertassinari oliviertassinari added the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Feb 8, 2020
@oliviertassinari oliviertassinari removed the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Feb 10, 2020
@oliviertassinari oliviertassinari merged commit e534b94 into mui:master Feb 10, 2020
@oliviertassinari
Copy link
Member

@jcafiero Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Difference between Lab and Core components?
4 participants