Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix typo in Autocomplete #19775

Merged
merged 2 commits into from
Feb 19, 2020
Merged

[docs] Fix typo in Autocomplete #19775

merged 2 commits into from
Feb 19, 2020

Conversation

aurnik
Copy link
Contributor

@aurnik aurnik commented Feb 19, 2020

The description for the selectOnFocus prop of Autocomplete had the word "clearning", which (based on the functionality) I'm assuming was meant to be "clear".

@aurnik
[docs] Fix typo
541577f 
The description for the `selectOnFocus` prop of `Autocomplete` had the word "clearning", which (based on the functionality) I'm assuming was meant to be "clear".
@mui-pr-bot
Copy link

mui-pr-bot commented Feb 19, 2020 •
edited
Loading

No bundle size changes comparing f2d74e9...c7dd87a

Generated by 🚫 dangerJS against c7dd87a

eps1lon
eps1lon previously requested changes Feb 19, 2020
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

We autogenerate the docs from the propTypes documentation. You have to edit the description in packages/material-ui-lab/Autocomplete/Autocomplete.js though and run yarn docs:api.

@eps1lon eps1lon added docs Improvements or additions to the documentation component: autocomplete This is the name of the generic UI component, not the React module! labels Feb 19, 2020
@oliviertassinari oliviertassinari added PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Feb 19, 2020
@oliviertassinari oliviertassinari changed the title [docs] Fix typo [docs] Fix typo in Autocomplete Feb 19, 2020
@oliviertassinari oliviertassinari merged commit fde2343 into mui:master Feb 19, 2020
@oliviertassinari
Copy link
Member

@aurnik Thank you for opening a pull request :)

@aurnik aurnik deleted the patch-1 branch February 20, 2020 00:19
This was referenced Mar 10, 2020
Merged
Closed
Open
This was referenced Mar 21, 2020
Merged
Open
Closed
This was referenced Apr 16, 2020
Merged
Closed
@snyk-bot snyk-bot mentioned this pull request May 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@eps1lon eps1lon eps1lon left review comments

Assignees
No one assigned
Labels
component: autocomplete This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aurnik @mui-pr-bot @oliviertassinari @eps1lon