[CardMedia] Fix propTypes to allow component prop
#19790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
the
component: card
|
@stevenmusumeche Thanks for the update of the prop-types. I'm not sure about the TypeScript update, I believe the types are already supposed to handle the prop. Could you look into the CI fails? :) |
|
@oliviertassinari I made those changes and everything in CI is passing now except for Azure pipelines: |
|
No bundle size changes comparing 264684b...7b5a7c6 |
oliviertassinari
approved these changes
Feb 21, 2020
|
@oliviertassinari thanks for approving. anything else needed from me? |
This was referenced Mar 21, 2020
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Mar 30, 2020
This was referenced Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CardMediaalready supports thecomponentprop, however, console errors are generated when using it in development mode. This change fixes that warning.