-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autocomplete] Fix list of countries #19862
Conversation
Someone mixed up the two country flags. 🇨🇩 and 🇨🇬 https://en.wikipedia.org/wiki/Flag_of_the_Democratic_Republic_of_the_Congo https://en.wikipedia.org/wiki/Flag_of_the_Republic_of_the_Congo
@@ -96,9 +96,9 @@ const countries = [ | |||
{ code: 'BZ', label: 'Belize', phone: '501' }, | |||
{ code: 'CA', label: 'Canada', phone: '1', suggested: true }, | |||
{ code: 'CC', label: 'Cocos (Keeling) Islands', phone: '61' }, | |||
{ code: 'CD', label: 'Congo, Republic of the', phone: '242' }, | |||
{ code: 'CG', label: 'Congo, Republic of the', phone: '243' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure? https://countrycode.org/congo
{ code: 'CG', label: 'Congo, Republic of the', phone: '243' }, | |
{ code: 'CG', label: 'Congo, Republic of the', phone: '242' }, |
No bundle size changes comparing 9143f70...1eb3d6e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update the TypeScript version of the demo
The guideline doesn't say if I shouldn't ask stupid questions, so here we go. |
There is no stupid questions. You don't have to worry about yarn workspaces. As you as you run yarn on the root folder, you should be fine. |
So it seems #19242 had already upgraded ts to the latest version. Or is there something I don't understand? |
To clarify, each demo has a version in JavaScript and in TypeScript. You will get more details in the failed log of the CI, if it dare to complete (it still pending). |
@FottyM Thanks for bringing this problem to light 💡! |
sure no problem. I now understand that I needed to change the typescript version of the example as well, and not the version of ts itself 😄 |
Someone mixed up the two country flags
Congo, DRC 🇨🇩
Congo, the Republic of 🇨🇬