Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dx] Missing React.createContext displayName #628

Closed
oliviertassinari opened this issue Sep 17, 2024 · 1 comment · Fixed by #735
Closed

[dx] Missing React.createContext displayName #628

oliviertassinari opened this issue Sep 17, 2024 · 1 comment · Fixed by #735
Assignees
Labels
dx Related to developers' experience enhancement This is not a bug, nor a new feature

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 17, 2024

Steps to reproduce

Some have it, e.g.

export const SliderContext = React.createContext<SliderContextValue | undefined>(undefined);
if (process.env.NODE_ENV !== 'production') {
SliderContext.displayName = 'SliderContext';
}

Others don't, e.g.

export const TabsListContext = React.createContext<TabsListContextValue | undefined>(undefined);

export const FormRootContext = React.createContext<FormRootContext>({

But I believe this matters from a DX perspective mui/material-ui#41168.

Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: -

@oliviertassinari oliviertassinari added status: waiting for maintainer These issues haven't been looked at yet by a maintainer dx Related to developers' experience labels Sep 17, 2024
@oliviertassinari oliviertassinari changed the title [dx] Update all React.createContext calls to have displayName [dx] Missing React.createContext displayName Sep 17, 2024
Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@github-actions github-actions bot removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 17, 2024
@oliviertassinari oliviertassinari added the enhancement This is not a bug, nor a new feature label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Related to developers' experience enhancement This is not a bug, nor a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants