[modal] Escape shouldn't trigger until IME is settled

[oliviertassinari]

Steps to reproduce

Steps:

1. Open https://master--base-ui.netlify.app/components/react-dialog/
2. Start typing into the input. Start a composite word. Press Escape to cancel it.

Current behavior

It closes the modal

Japanese:

Screen.Recording.2024-10-02.at.00.26.33.mov

French:

Screen.Recording.2024-10-02.at.00.26.13.mov

Expected behavior

It only closes the composite selector. https://mui.com/base-ui/react-modal/#component

Screen.Recording.2024-10-02.at.00.31.32.mov

Context

• It's easy to fix. See how it was fixed in the PR linked below.
• It's a regression from @mui/base. It works correctly there since this change was made: [material-ui][Dialog] Should not close until the IME is cancelled material-ui#39713.
• As for where this is broken, it seems to be from https://github.com/floating-ui/floating-ui/blob/ecd627e4676a50643edcdf8915a6acefa50ee3d8/packages/react/src/hooks/useDismiss.ts#L159.
• It's a low priority, we lived with this bug for a very long time in Material UI, so to fix, but for later.

[oliviertassinari]

@naaa760 This is low priority, we have no plan to fix it in the short term.

[atomiks]

If event.isComposing is unreliable in Safari then Number Field also needs to change to the event.which technique.

base-ui/packages/mui-base/src/NumberField/Root/useNumberFieldRoot.ts

Line 665 in cab77be

nativeEvent.isComposing ||

[github-actions]

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

[oliviertassinari]

Reopening, #803 fixes a different component. Dialog Material UI -> Base UI regression is still present.

[atomiks]

It's fixed but in an upstream dependency

The issue for popups was fixed in Floating UI already

[oliviertassinari]

Ah, so floating-ui/floating-ui#3075.

[github-actions]

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.