Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Upgrade to Tailwind v4-alpha #771

Merged
merged 6 commits into from
Oct 30, 2024
Merged

Conversation

vladmoroz
Copy link
Contributor

Upgrading to remove unnecessary CSS variables spam in dev tools.

No changes to the produced CSS.

More details on the version:
https://tailwindcss.com/blog/tailwindcss-v4-alpha

@@ -188,22 +188,22 @@
padding: 16px;
font-family: IBM Plex Sans;

h1 {
& h1 {
Copy link
Contributor Author

@vladmoroz vladmoroz Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of a sudden CSS Modules started acting out, saying the selector isn't pure? (Because now it doesn't understand it without an explicit &). Not sure how this is related to the Tailwind upgrade. Anyway, I like explicit &

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Config is now in CSS
  • There's no content configuration anymore, they are saying it knows what to look at automatically

@mui-bot
Copy link

mui-bot commented Oct 30, 2024

Netlify deploy preview

https://deploy-preview-771--base-ui.netlify.app/

Generated by 🚫 dangerJS against 1a79f72

@vladmoroz vladmoroz added the docs Improvements or additions to the documentation label Oct 30, 2024
@vladmoroz vladmoroz requested a review from colmtuite as a code owner October 30, 2024 18:36
@vladmoroz vladmoroz merged commit 9b5ce28 into mui:master Oct 30, 2024
18 checks passed
@vladmoroz vladmoroz deleted the tailwind-v4 branch October 30, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants