Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onChange does not follow the normal event handling design pattern #1407

Closed
FoxyWolfy opened this issue Nov 26, 2019 · 3 comments
Closed

onChange does not follow the normal event handling design pattern #1407

FoxyWolfy opened this issue Nov 26, 2019 · 3 comments

Comments

@FoxyWolfy
Copy link

FoxyWolfy commented Nov 26, 2019

Tech Version
@material-ui/pickers v3.2.8

onChange does not follow normal event handling design pattern. Please provide the original DOM event to onChange.

o Always provide the event as the first argument to any user facing event prop handler
o The "event.target" needs to be supplied
o The "event.target.name" should be the control name
o The "event.target.value" should contain the "date"

What's not obvious is where the date originated from. Without the event a complex app doesn't have the originating "event.target" and therefore cannot determine the originating control with "event.target.name".

All we get is a "date". From which control? We have multiple modules with dozens of controls that send changes up to a parent. This is the only control that doesn't forward the event on an onChange.

We cannot use material-ui-pickers until onChange supports the established event handling design pattern

@FoxyWolfy FoxyWolfy changed the title Provide original DOM event to onChange onChange does not follow the normal event handling design pattern Nov 26, 2019
@dmtrKovalenko
Copy link
Member

Duplicate of tons of issues

@FoxyWolfy
Copy link
Author

FoxyWolfy commented Nov 27, 2019

Aren't you suppose to link this issue to the duplicate issue?
Just closing issues as you are doing displays extremely poor development methodology.

@dmtrKovalenko
Copy link
Member

dmtrKovalenko commented Nov 27, 2019

Only issues that was found super fast, there are more #182, #473, #483, #644, #974. Please try to search through the currently closed issues before opening new one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants