Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tabs][TS] react warns about indicatorClassName, but it is on the TS definition #10623

Closed
xaviergonz opened this issue Mar 12, 2018 · 3 comments
Labels
good first issue Great for first contributions. Enable to learn the contribution process. typescript

Comments

@xaviergonz
Copy link
Contributor

xaviergonz commented Mar 12, 2018

When using Tabs there's this warning:

Warning: React does not recognize the `indicatorClassName` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `indicatorclassname` instead. If you accidentally passed it from a parent component, remove it from the DOM element.

yet it is on the TS definitions, I think this was due to the recent changes to classes and that the TS definitions were not updated.

@xaviergonz
Copy link
Contributor Author

xaviergonz commented Mar 12, 2018

Oh, and TS complains about this when trying to fix it:

<Tabs classes={{ indicator: 'whatever' }} />

Types of property 'classes' are incompatible.
      Type '{ indicator: string; }' is not assignable to type 'Partial<Record<TabsClassKey, string>> | undefined'.
        Property 'indicator' does not exist on type 'Partial<Record<TabsClassKey, string>> | undefined'.

@oliviertassinari oliviertassinari added typescript good first issue Great for first contributions. Enable to learn the contribution process. labels Mar 12, 2018
@oliviertassinari
Copy link
Member

@oliviertassinari
Copy link
Member

Ok, it was fixed in #10618.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Great for first contributions. Enable to learn the contribution process. typescript
Projects
None yet
Development

No branches or pull requests

2 participants