Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu component demo documentation crash on Edge 42 #11607

Closed
arialpew opened this issue May 27, 2018 · 3 comments
Closed

Menu component demo documentation crash on Edge 42 #11607

arialpew opened this issue May 27, 2018 · 3 comments
Assignees
Labels
bug 🐛 Something doesn't work

Comments

@arialpew
Copy link

arialpew commented May 27, 2018

Material-ui docs : https://material-ui.com/demos/

Menu component demo : https://material-ui.com/demos/menus/

Version : v1.1

Browser : Microsoft Edge 42.17134.1.0

When you go on Menu component demo, documentation crash and show error message :

"An unexpected error has occurred"

Stacktrace :

Invalid attempt to spread non-iterable instance
TypeError: Invalid attempt to spread non-iterable instance
   at r (https://material-ui.com/_next/static/commons/main-a152ab07849ea9fef63e.js:1:438070)
   at i (https://material-ui.com/_next/static/commons/main-a152ab07849ea9fef63e.js:1:43975)
   at e (https://material-ui.com/_next/static/commons/main-a152ab07849ea9fef63e.js:1:646895)
   at e (https://material-ui.com/_next/static/commons/main-a152ab07849ea9fef63e.js:1:646403)
   at commitLifeCycles (https://material-ui.com/_next/static/commons/main-a152ab07849ea9fef63e.js:1:110047)
   at w (https://material-ui.com/_next/static/commons/main-a152ab07849ea9fef63e.js:1:121715)
   at x (https://material-ui.com/_next/static/commons/main-a152ab07849ea9fef63e.js:1:120501)
   at y (https://material-ui.com/_next/static/commons/main-a152ab07849ea9fef63e.js:1:120033)
   at g (https://material-ui.com/_next/static/commons/main-a152ab07849ea9fef63e.js:1:119870)
   at v (https://material-ui.com/_next/static/commons/main-a152ab07849ea9fef63e.js:1:119204)

Unable to get property 'firstChild' of undefined or null reference
...

CodeSandbox of first Menu example : https://codesandbox.io/s/5xv8x0mo54 (produces the same error, it's more serious than I thought. That comes from material-ui/core ?).

Stacktrace :

TypeError Invalid attempt to spread non-iterable instance
_nonIterableSpread (eval code:2:3)
_toConsumableArray (eval code:8:3)
resetTabIndex (eval code:159:7)
componentDidMount (eval code:122:7)
commitLifeCycles (eval code:14248:13)
commitAllLifeCycles (eval code:15342:7)
callCallback (eval code:100:9)

TypeError Unable to get property 'firstChild' of undefined or null reference
_this.getContentAnchorEl (eval code:77:9)
getContentAnchorOffset (eval code:273:9)
_this.getPositioningStyle (eval code:155:7)
_this.setPositioningStyles (eval code:137:9)
_this.handleEnter (eval code:221:7)
_this.handleEnter (eval code:100:9)
performEnter (eval code:265:5)
updateStatus (eval code:238:9)
componentDidMount (eval code:180:5)
commitLifeCycles (eval)
The above error occurred in the MenuList> component:
    in MenuList (created by Menu)
    in div (created by Paper)
    in Paper (created by WithStyles(Paper))
    in WithStyles(Paper) (created by Popover)
    in Transition (created by Grow)
    in Grow (created by WithTheme(Grow))
    in WithTheme(Grow) (created by Popover)
    in RootRef (created by Modal)
    in div (created by Modal)
    in Portal (created by Modal)
    in Modal (created by WithStyles(Modal))
    in WithStyles(Modal) (created by Popover)
    in Popover (created by WithStyles(Popover))
    in WithStyles(Popover) (created by Menu)
    in Menu (created by WithStyles(Menu))
    in WithStyles(Menu) (created by SimpleMenu)
    in div (created by SimpleMenu)
    in SimpleMenu

The above error occurred in the Transition> component:
    in Transition (created by Grow)
    in Grow (created by WithTheme(Grow))
    in WithTheme(Grow) (created by Popover)
    in RootRef (created by Modal)
    in div (created by Modal)
    in Portal (created by Modal)
    in Modal (created by WithStyles(Modal))
    in WithStyles(Modal) (created by Popover)
    in Popover (created by WithStyles(Popover))
    in WithStyles(Popover) (created by Menu)
    in Menu (created by WithStyles(Menu))
    in WithStyles(Menu) (created by SimpleMenu)
    in div (created by SimpleMenu)
    in SimpleMenu

Old version (like https://v1-0-0.material-ui.com/demos/menus/) doesn't have this issue.

@oliviertassinari oliviertassinari self-assigned this May 27, 2018
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label May 27, 2018
@vudzero
Copy link

vudzero commented May 27, 2018

I confirm same issue here

@oliviertassinari
Copy link
Member

My bandwidth yesterday was too slow to confirm this theory. The issue could be coming from:
https://github.com/mui-org/material-ui/blob/999d06fd8444213bb0f8aae279c4c20db363b45d/packages/material-ui/src/MenuList/MenuList.js#L109

@mbrookes
Copy link
Member

mbrookes commented May 28, 2018

@oliviertassinari spot on:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
Development

No branches or pull requests

4 participants