-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Slider] Value can still be updated while disabled #11738
Comments
@rolandjitsu are you planning on working on this issue? or should I? |
@adeelibr not today, I'm out of the office. I can do it tomorrow unless you'd like to work on it :) |
I'd love to work on it. :) |
Fixed in this PR |
Oh ooh! I just made a PR as well #11746 I guess you can delete my PR now. :) |
Kindly next time if you are about to make a PR on an issue, mention so that anyone about to work wouldn't work on it. :) @epodivilov |
@adeelibr Yes, sure. I will always refresh the page before writing a comment about PR :) |
Cheers. :) So now how do I delete my PR? |
I somehow accidentally closed the PR by deleting the branch in my version of the repository. But I think one of members can close PR and it will be more correct :) |
Expected Behavior
If the slider is disabled, changing its value using the knob should not be allowed/not work.
Current Behavior
I can still drag and set the slider value using the knob.
Steps to Reproduce (for bugs)
Context
Your Environment
Using latest of
@material-ui/lab
(1.0.0-alpha.4
).The text was updated successfully, but these errors were encountered: