Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slider] Value can still be updated while disabled #11738

Closed
2 tasks done
rolandjitsu opened this issue Jun 6, 2018 · 9 comments
Closed
2 tasks done

[Slider] Value can still be updated while disabled #11738

rolandjitsu opened this issue Jun 6, 2018 · 9 comments
Labels
component: slider This is the name of the generic UI component, not the React module!

Comments

@rolandjitsu
Copy link
Contributor

  • This is a v1.x issue (v0.x is no longer maintained).
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

If the slider is disabled, changing its value using the knob should not be allowed/not work.

Current Behavior

I can still drag and set the slider value using the knob.

Steps to Reproduce (for bugs)

  1. See zl5xopv1lp
  2. Try dragging the know or click at any distance on the slider

Context

Your Environment

Using latest of @material-ui/lab (1.0.0-alpha.4).

Tech Version
Material-UI v1.?.?
React
browser
etc
@oliviertassinari oliviertassinari added component: slider This is the name of the generic UI component, not the React module! package: lab Specific to @mui/lab labels Jun 6, 2018
@adeelibr
Copy link
Contributor

adeelibr commented Jun 6, 2018

@rolandjitsu are you planning on working on this issue? or should I?

@rolandjitsu
Copy link
Contributor Author

@adeelibr not today, I'm out of the office. I can do it tomorrow unless you'd like to work on it :)

@adeelibr
Copy link
Contributor

adeelibr commented Jun 6, 2018

I'd love to work on it. :)

@epodivilov
Copy link
Contributor

Fixed in this PR

@adeelibr
Copy link
Contributor

adeelibr commented Jun 6, 2018

Oh ooh! I just made a PR as well #11746 I guess you can delete my PR now. :)

@adeelibr
Copy link
Contributor

adeelibr commented Jun 6, 2018

Kindly next time if you are about to make a PR on an issue, mention so that anyone about to work wouldn't work on it. :) @epodivilov

@epodivilov
Copy link
Contributor

@adeelibr Yes, sure. I will always refresh the page before writing a comment about PR :)

@adeelibr
Copy link
Contributor

adeelibr commented Jun 6, 2018

Cheers. :) So now how do I delete my PR?

@epodivilov
Copy link
Contributor

I somehow accidentally closed the PR by deleting the branch in my version of the repository. But I think one of members can close PR and it will be more correct :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: slider This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

4 participants