Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JSS] Pseudo elements are not working #11839

Closed
2 tasks done
cherniavskii opened this issue Jun 13, 2018 · 7 comments
Closed
2 tasks done

[JSS] Pseudo elements are not working #11839

cherniavskii opened this issue Jun 13, 2018 · 7 comments
Labels
external dependency Blocked by external dependency, we can’t do anything about it support: Stack Overflow Please ask the community on Stack Overflow

Comments

@cherniavskii
Copy link
Member

  • This is a v1.x issue (v0.x is no longer maintained).
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Pseudo elements (::before and ::after) are working.

Current Behavior

Pseudo elements (::before and ::after) are not working.

Steps to Reproduce (for bugs)

  1. https://codesandbox.io/s/x2yv65109q
  2. ::before styles are applied to Button, but are not visible (even in dev tools)

Context

Note, that custom JssProvider is not configured - I'm just using single component from @material-ui/core. But I believe I don't have to configure JssProvider to make jss plugins work.

Also, looks like other pseudo-selectors are not working too.

Am I doing something wrong?

Your Environment

Tech Version
Material-UI v1.2.1
React 16.3.2
browser Chrome
etc
@oliviertassinari oliviertassinari added the external dependency Blocked by external dependency, we can’t do anything about it label Jun 13, 2018
@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 13, 2018

  button: {
    "&::before": {
-     content: "before"
+     content: "'before'"
    }
  }

@oliviertassinari oliviertassinari added support: Stack Overflow Please ask the community on Stack Overflow and removed external dependency Blocked by external dependency, we can’t do anything about it labels Jun 13, 2018
@support
Copy link

support bot commented Jun 13, 2018

👋 Thanks for using Material-UI!

We use the issue tracker exclusively for bug reports and feature requests, however,
this issue appears to be a support request or question. Please ask on StackOverflow where the
community will do their best to help. There is a "material-ui" tag that you can use to tag your
question.

If you would like to link from here to your question on SO, it will help others find it.
If your issues is confirmed as a bug, you are welcome to reopen the issue using the issue template.

@oliviertassinari oliviertassinari added the external dependency Blocked by external dependency, we can’t do anything about it label Jun 13, 2018
@cherniavskii
Copy link
Member Author

@oliviertassinari Thanks! Sorry for such a silly question

@sekoyo
Copy link

sekoyo commented Aug 30, 2019

What if we want to use a space for content? In normal css '' or ' ' works but not with JSS?

@sekoyo
Copy link

sekoyo commented Aug 30, 2019

Never mind solved it as per @oliviertassinari comment here cssinjs/jss#242 (comment)

@wojciechszuckosagacapital

This comment has been minimized.

@mInzamamMalik

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external dependency Blocked by external dependency, we can’t do anything about it support: Stack Overflow Please ask the community on Stack Overflow
Projects
None yet
Development

No branches or pull requests

5 participants